linux-kernel - Re: [PATCH v1 4/5] ACPI: processor: Rescan "dead" SMT siblings during initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06122416-b24a-493b-9374-550e5c290436@intel.com>
Date: Thu, 5 Jun 2025 09:14:54 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: "Rafael J. Wysocki" <rjw@...ysocki.net>, x86 Maintainers
 <x86@...nel.org>, Linux PM <linux-pm@...r.kernel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Len Brown <lenb@...nel.org>,
 Peter Zijlstra <peterz@...radead.org>, Thomas Gleixner <tglx@...utronix.de>,
 Dave Hansen <dave.hansen@...ux.intel.com>,
 Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>,
 "Gautham R. Shenoy" <gautham.shenoy@....com>, Ingo Molnar
 <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
 Linux ACPI <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH v1 4/5] ACPI: processor: Rescan "dead" SMT siblings during
 initialization

On 6/5/25 08:07, Rafael J. Wysocki wrote:
>  #ifdef CONFIG_ACPI_PROCESSOR_CSTATE
> +void acpi_idle_rescan_dead_smt_siblings(void)
> +{
> +	if (cpuidle_get_driver() == &acpi_idle_driver)
> +		arch_cpu_rescan_dead_smt_siblings();
> +}

My only thought in reading this is that maybe cpuidle_register_driver()
would be a better spot to force the arch_cpu_rescan_dead_smt_siblings().
That way, each driver would not have to do the rescan.

But that's just a little nit at worst, otherwise the series looks good
to me. Thanks for chasing this down.

For the x86 bits:

Acked-by: Dave Hansen <dave.hansen@...ux.intel.com>