linux-kernel - Re: [PATCH bpf-next 1/2] bpftool: skel: Introduce NAME__open_and_load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4BzYkyt-sXrxJFSHrJX_NS0nBK=NbfkTt71VLKsnXA7A56A@mail.gmail.com>
Date: Thu, 5 Jun 2025 09:45:02 -0700
From: Andrii Nakryiko <andrii.nakryiko@...il.com>
To: Rong Tao <rtoax@...mail.com>
Cc: Quentin Monnet <qmo@...nel.org>, Alexei Starovoitov <ast@...nel.org>, 
	Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>, 
	Martin KaFai Lau <martin.lau@...ux.dev>, Eduard Zingerman <eddyz87@...il.com>, Song Liu <song@...nel.org>, 
	Yonghong Song <yonghong.song@...ux.dev>, John Fastabend <john.fastabend@...il.com>, 
	KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>, 
	Jiri Olsa <jolsa@...nel.org>, 
	"open list:BPF [TOOLING] (bpftool)" <bpf@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>, rongtao@...tc.cn
Subject: Re: [PATCH bpf-next 1/2] bpftool: skel: Introduce NAME__open_and_load_opts()

On Thu, Jun 5, 2025 at 12:57 AM Rong Tao <rtoax@...mail.com> wrote:
>
> From: Rong Tao <rongtao@...tc.cn>
>
> Introduce functions that support opts input parameters, Obviously, it is
> more convenient to use. for example, skel with name=tc will include the

No, I don't see the need to add one extra variant just to add a bit
more convenience. If you need opts at open, then just do open_opts,
followed by load.

If we take this convenience to its logical conclusion, we'd need to
add open_and_load_and_attach() and open_and_load_and_attach_opts().
And yes, that would save a few lines of code here and there, but I
don't think we should do it.

pw-bot: cr

> following functions:
>
>     static inline struct tc_bpf *
>     tc_bpf__open_and_load_opts(const struct bpf_object_open_opts *opts)
>
> Signed-off-by: Rong Tao <rongtao@...tc.cn>
> ---
>  tools/bpf/bpftool/gen.c | 17 ++++++++++++++---
>  1 file changed, 14 insertions(+), 3 deletions(-)
>

[...]