linux-kernel - Re: [PATCH net] gve: Fix stuck TX queue for DQ queue format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAByH8UvMV94aVmmwb37f-wT8HpPKB3Nf8AF+67FM87XBz7+pww@mail.gmail.com>
Date: Thu, 5 Jun 2025 10:15:51 -0700
From: Tim Hostetler <thostet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Harshitha Ramamurthy <hramamurthy@...gle.com>, netdev@...r.kernel.org, davem@...emloft.net, 
	edumazet@...gle.com, pabeni@...hat.com, jeroendb@...gle.com, 
	andrew+netdev@...n.ch, willemb@...gle.com, pkaligineedi@...gle.com, 
	joshwash@...gle.com, jfraker@...gle.com, awogbemila@...gle.com, 
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH net] gve: Fix stuck TX queue for DQ queue format

On Thu, Jun 5, 2025 at 8:13 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed,  4 Jun 2025 20:19:38 +0000 Harshitha Ramamurthy wrote:
> > +     netdev_info(dev, "Kicking queue %d", txqueue);
> > +     napi_schedule(&block->napi);
> > +     tx->last_kick_msec = current_time;
> > +     goto out;
> >
> >  reset:
> >       gve_schedule_reset(priv);
>
> gotos at the base level of the function are too ugly to exit.
>
> Please refactor this first to move the logic that decides whether
> reset should happen to a separate helper, then you can avoid both
> gotos/labels.
>
> goto reset should turn into return true
> goto out should turn into return false

That makes sense to me, I'll refactor this in v2.