linux-kernel - Re: [PATCH v3] mm: use per_vma lock for MADV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250607093344.15699-1-21cnbao@gmail.com>
Date: Sat,  7 Jun 2025 21:33:44 +1200
From: Barry Song <21cnbao@...il.com>
To: lorenzo.stoakes@...cle.com,
	akpm@...ux-foundation.org
Cc: 21cnbao@...il.com,
	Liam.Howlett@...cle.com,
	david@...hat.com,
	jannh@...gle.com,
	linux-kernel@...r.kernel.org,
	linux-mm@...ck.org,
	lokeshgidra@...gle.com,
	surenb@...gle.com,
	v-songbaohua@...o.com,
	vbabka@...e.cz,
	zhengqi.arch@...edance.com,
	zhengtangquan@...o.com
Subject: Re: [PATCH v3] mm: use per_vma lock for MADV_DONTNEED

>
> Whoops, I should add R-b only applies with the fix-patch proposed in [0].
>
> [0]: https://lore.kernel.org/all/CAGsJ_4x1RbQ+GKKc1rrTaNA8Xd+W8K-Zu6-kwVYNKzB0OWiowQ@mail.gmail.com/
>
> Barry - Probably worth respinning a v4 to pick that up to make things
> clear, you can propagate my tag with that.

Sure. It's a small, non-functional change:

diff --git a/mm/madvise.c b/mm/madvise.c
index a94e6a7ee387..8382614b71d1 100644
--- a/mm/madvise.c
+++ b/mm/madvise.c
@@ -1534,8 +1534,7 @@ int madvise_walk_vmas(struct mm_struct *mm, unsigned long start,
 	if (madv_behavior && madv_behavior->lock_mode == MADVISE_VMA_READ_LOCK) {
 		vma = try_vma_read_lock(mm, madv_behavior, start, end);
 		if (vma) {
-			error = madvise_vma_behavior(vma, &prev, start, end,
-				madv_behavior);
+			error = visit(vma, &prev, start, end, arg);
 			vma_end_read(vma);
 			return error;
 		}

>
> Cheers, Lorenzo

Thanks
Barry