linux-kernel - Re: [PATCH v11 4/9] PCI: stm32: Add PCIe Endpoint support for STM32MP25

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202506071838.C54p5js2-lkp@intel.com>
Date: Sat, 7 Jun 2025 19:01:10 +0800
From: kernel test robot <lkp@...el.com>
To: Christian Bruel <christian.bruel@...s.st.com>, bhelgaas@...gle.com,
	lpieralisi@...nel.org, kwilczynski@...nel.org,
	manivannan.sadhasivam@...aro.org, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, mcoquelin.stm32@...il.com,
	alexandre.torgue@...s.st.com, p.zabel@...gutronix.de,
	quic_schintav@...cinc.com, shradha.t@...sung.com, cassel@...nel.org,
	thippeswamy.havalige@....com
Cc: oe-kbuild-all@...ts.linux.dev, linux-pci@...r.kernel.org,
	devicetree@...r.kernel.org,
	linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v11 4/9] PCI: stm32: Add PCIe Endpoint support for
 STM32MP25

Hi Christian,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 911483b25612c8bc32a706ba940738cc43299496]

url:    https://github.com/intel-lab-lkp/linux/commits/Christian-Bruel/dt-bindings-PCI-Add-STM32MP25-PCIe-Root-Complex-bindings/20250606-201204
base:   911483b25612c8bc32a706ba940738cc43299496
patch link:    https://lore.kernel.org/r/20250606120403.2964857-5-christian.bruel%40foss.st.com
patch subject: [PATCH v11 4/9] PCI: stm32: Add PCIe Endpoint support for STM32MP25
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20250607/202506071838.C54p5js2-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250607/202506071838.C54p5js2-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506071838.C54p5js2-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/pci/controller/dwc/pcie-stm32-ep.c: In function 'stm32_pcie_probe':
>> drivers/pci/controller/dwc/pcie-stm32-ep.c:339:79: warning: format '%d' expects a matching 'int' argument [-Wformat=]
     339 |                 return dev_err_probe(dev, ret, "Failed to request PERST IRQ: %d\n");
         |                                                                              ~^
         |                                                                               |
         |                                                                               int


vim +339 drivers/pci/controller/dwc/pcie-stm32-ep.c

   275	
   276	static int stm32_pcie_probe(struct platform_device *pdev)
   277	{
   278		struct stm32_pcie *stm32_pcie;
   279		struct device *dev = &pdev->dev;
   280		int ret;
   281	
   282		stm32_pcie = devm_kzalloc(dev, sizeof(*stm32_pcie), GFP_KERNEL);
   283		if (!stm32_pcie)
   284			return -ENOMEM;
   285	
   286		stm32_pcie->pci.dev = dev;
   287		stm32_pcie->pci.ops = &dw_pcie_ops;
   288	
   289		stm32_pcie->regmap = syscon_regmap_lookup_by_compatible("st,stm32mp25-syscfg");
   290		if (IS_ERR(stm32_pcie->regmap))
   291			return dev_err_probe(dev, PTR_ERR(stm32_pcie->regmap),
   292					     "No syscfg specified\n");
   293	
   294		stm32_pcie->phy = devm_phy_get(dev, NULL);
   295		if (IS_ERR(stm32_pcie->phy))
   296			return dev_err_probe(dev, PTR_ERR(stm32_pcie->phy),
   297					     "failed to get pcie-phy\n");
   298	
   299		stm32_pcie->clk = devm_clk_get(dev, NULL);
   300		if (IS_ERR(stm32_pcie->clk))
   301			return dev_err_probe(dev, PTR_ERR(stm32_pcie->clk),
   302					     "Failed to get PCIe clock source\n");
   303	
   304		stm32_pcie->rst = devm_reset_control_get_exclusive(dev, NULL);
   305		if (IS_ERR(stm32_pcie->rst))
   306			return dev_err_probe(dev, PTR_ERR(stm32_pcie->rst),
   307					     "Failed to get PCIe reset\n");
   308	
   309		stm32_pcie->perst_gpio = devm_gpiod_get(dev, "reset", GPIOD_IN);
   310		if (IS_ERR(stm32_pcie->perst_gpio))
   311			return dev_err_probe(dev, PTR_ERR(stm32_pcie->perst_gpio),
   312					     "Failed to get reset GPIO\n");
   313	
   314		ret = phy_set_mode(stm32_pcie->phy, PHY_MODE_PCIE);
   315		if (ret)
   316			return ret;
   317	
   318		platform_set_drvdata(pdev, stm32_pcie);
   319	
   320		pm_runtime_get_noresume(dev);
   321	
   322		ret = devm_pm_runtime_enable(dev);
   323		if (ret < 0) {
   324			pm_runtime_put_noidle(&pdev->dev);
   325			return dev_err_probe(dev, ret, "Failed to enable runtime PM\n");
   326		}
   327	
   328		stm32_pcie->perst_irq = gpiod_to_irq(stm32_pcie->perst_gpio);
   329	
   330		/* Will be enabled in start_link when device is initialized. */
   331		irq_set_status_flags(stm32_pcie->perst_irq, IRQ_NOAUTOEN);
   332	
   333		ret = devm_request_threaded_irq(dev, stm32_pcie->perst_irq, NULL,
   334						stm32_pcie_ep_perst_irq_thread,
   335						IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
   336						"perst_irq", stm32_pcie);
   337		if (ret) {
   338			pm_runtime_put_noidle(&pdev->dev);
 > 339			return dev_err_probe(dev, ret, "Failed to request PERST IRQ: %d\n");
   340		}
   341	
   342		ret = stm32_add_pcie_ep(stm32_pcie, pdev);
   343		if (ret)
   344			pm_runtime_put_noidle(&pdev->dev);
   345	
   346		return ret;
   347	}
   348	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki