linux-kernel - Re: [PATCH v3 2/3] misc: add driver for ST M24LR series RFID/NFC EEPROM chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202506071933.QIYSWX1a-lkp@intel.com>
Date: Sat, 7 Jun 2025 19:33:20 +0800
From: kernel test robot <lkp@...el.com>
To: Abd-Alrhman Masalkhi <abd.masalkhi@...il.com>,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, arnd@...db.de,
	gregkh@...uxfoundation.org, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, abd.masalkhi@...il.com
Subject: Re: [PATCH v3 2/3] misc: add driver for ST M24LR series RFID/NFC
 EEPROM chips

Hi Abd-Alrhman,

kernel test robot noticed the following build warnings:

[auto build test WARNING on char-misc/char-misc-linus]
[also build test WARNING on soc/for-next robh/for-next driver-core/driver-core-testing driver-core/driver-core-next driver-core/driver-core-linus v6.15]
[cannot apply to char-misc/char-misc-testing char-misc/char-misc-next linus/master next-20250606]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Abd-Alrhman-Masalkhi/dt-bindings-eeprom-Add-ST-M24LR-support/20250606-201000
base:   char-misc/char-misc-linus
patch link:    https://lore.kernel.org/r/20250606120631.3140054-3-abd.masalkhi%40gmail.com
patch subject: [PATCH v3 2/3] misc: add driver for ST M24LR series RFID/NFC EEPROM chips
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20250607/202506071933.QIYSWX1a-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250607/202506071933.QIYSWX1a-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506071933.QIYSWX1a-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/misc/m24lr.c:341: warning: Function parameter or struct member 'is_eeprom' not described in 'm24lr_write'


vim +341 drivers/misc/m24lr.c

   322	
   323	/**
   324	 * m24lr_write - write buffer to M24LR device with page alignment handling
   325	 * @m24lr:  pointer to driver context
   326	 * @buf:    data buffer to write
   327	 * @size:   number of bytes to write
   328	 * @offset: target register address in the device
   329	 *
   330	 * Writes data to the M24LR device using regmap, split into chunks no larger
   331	 * than page_size to respect device-specific write limitations (e.g., page
   332	 * size or I2C hold-time concerns). Each chunk is aligned to the page boundary
   333	 * defined by page_size.
   334	 *
   335	 * Returns:
   336	 *	 Total number of bytes written on success,
   337	 *	 A negative error code if any write fails.
   338	 */
   339	static ssize_t m24lr_write(struct m24lr *m24lr, const u8 *buf, size_t size,
   340				   unsigned int offset, bool is_eeprom)
 > 341	{
   342		unsigned int n, next_sector;
   343		struct regmap *regmap;
   344		ssize_t ret = 0;
   345		long err;
   346	
   347		if (is_eeprom)
   348			regmap = m24lr->eeprom_regmap;
   349		else
   350			regmap = m24lr->ctl_regmap;
   351	
   352		n = min(size, m24lr->page_size);
   353		next_sector = roundup(offset + 1, m24lr->page_size);
   354		if (offset + n > next_sector)
   355			n = next_sector - offset;
   356	
   357		mutex_lock(&m24lr->lock);
   358		while (n) {
   359			err = m24lr_regmap_write(regmap, buf, n, offset);
   360			if (IS_ERR_VALUE(err)) {
   361				mutex_unlock(&m24lr->lock);
   362				if (ret)
   363					return ret;
   364				else
   365					return err;
   366			}
   367	
   368			offset += n;
   369			size -= n;
   370			ret += n;
   371			n = min(size, m24lr->page_size);
   372		}
   373		mutex_unlock(&m24lr->lock);
   374	
   375		return ret;
   376	}
   377	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki