linux-kernel - Re: [PATCH v4 01/11] dt-bindings: iio: adc: Add AD4170

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250607173320.46e88253@jic23-huawei>
Date: Sat, 7 Jun 2025 17:33:20 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Marcelo Schmitt <marcelo.schmitt1@...il.com>
Cc: "Rob Herring (Arm)" <robh@...nel.org>, Marcelo Schmitt
 <marcelo.schmitt@...log.com>, nuno.sa@...log.com, andy@...nel.org,
 linus.walleij@...aro.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Michael.Hennerich@...log.com,
 conor+dt@...nel.org, linux-iio@...r.kernel.org, brgl@...ev.pl,
 dlechner@...libre.com, lars@...afoo.de, krzk+dt@...nel.org,
 linux-gpio@...r.kernel.org
Subject: Re: [PATCH v4 01/11] dt-bindings: iio: adc: Add AD4170

On Mon, 2 Jun 2025 17:52:31 -0300
Marcelo Schmitt <marcelo.schmitt1@...il.com> wrote:

> On 06/02, Rob Herring (Arm) wrote:
> > 
> > On Mon, 02 Jun 2025 08:36:24 -0300, Marcelo Schmitt wrote:  
> > > Add device tree documentation for AD4170 and similar sigma-delta ADCs.
> > > The AD4170 is a 24-bit, multichannel, sigma-delta ADC.
> > > 
> > > Signed-off-by: Marcelo Schmitt <marcelo.schmitt@...log.com>  
> >   
> ...
> > My bot found errors running 'make dt_binding_check' on your patch:
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/adi,ad4170.yaml: properties:interrupt-names: 'enum' should not be valid under {'enum': ['const', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'minimum', 'maximum', 'multipleOf', 'pattern']}
> > 	hint: Scalar and array keywords cannot be mixed
> > 	from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#  
> 
> Removing maxItems from under interrupt-names seems to solve the issue.

As per feedback on v3.  I don't think we should be limiting the max
of interrupt-names anyway.  We should allow two interrupts if they
are both wired - it's a driver choice on which one to use.

> 
> Thanks
>