linux-kernel - Re: [PATCH v2 1/3] PCI/pwrctrl: Add optional slot clock to pwrctrl driver for PCI slots

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e4d82284-d6e3-49d0-856e-e347d9d0de55@mailbox.org>
Date: Sat, 7 Jun 2025 21:48:03 +0200
From: Marek Vasut <marek.vasut@...lbox.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>,
 Marek Vasut <marek.vasut+renesas@...lbox.org>
Cc: linux-arm-kernel@...ts.infradead.org, Anand Moon <linux.amoon@...il.com>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Bartosz Golaszewski <brgl@...ev.pl>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Conor Dooley <conor+dt@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Magnus Damm <magnus.damm@...il.com>,
 Rob Herring <robh@...nel.org>,
 Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pci@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v2 1/3] PCI/pwrctrl: Add optional slot clock to pwrctrl
 driver for PCI slots

On 6/4/25 10:40 AM, Geert Uytterhoeven wrote:
> Hi Marek,

Hi,

> Thanks for your patch!
> 
> On Sat, 31 May 2025 at 00:55, Marek Vasut
> <marek.vasut+renesas@...lbox.org> wrote:
>> Add the ability to enable optional slot clock into the pwrctrl driver.
>> This is used to enable slot clock in split-clock topologies, where the
>> PCIe host/controller supply and PCIe slot supply are not provided by
>> the same clock. The PCIe host/controller clock should be described in
>> the controller node as the controller clock, while the slot clock should
>> be described in controller bridge/slot subnode.
>>
>> Example DT snippet:
>> &pcicontroller {
>>      clocks = <&clk_dif 0>;             /* PCIe controller clock */
>>
>>      pci@0,0 {
>>          #address-cells = <3>;
>>          #size-cells = <2>;
>>          reg = <0x0 0x0 0x0 0x0 0x0>;
>>          compatible = "pciclass,0604";
>>          device_type = "pci";
>>          clocks = <&clk_dif 1>;         /* PCIe slot clock */
> 
> I assume this should be documented in
> dtschema/schemas/pci/pci-bus-common.yaml, too?
Patch posted:

https://lore.kernel.org/all/20250607194353.79124-1-marek.vasut+renesas@mailbox.org/

The rest is fixed in V3, thanks.