linux-kernel - Re: [PATCH] vhost-scsi: Fix check for inline_sg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a6fee3e-989f-4259-a753-ecee3fddfa38@oracle.com>
Date: Sat, 7 Jun 2025 15:30:24 -0500
From: Mike Christie <michael.christie@...cle.com>
To: Alok Tiwari <alok.a.tiwari@...cle.com>, mst@...hat.com,
        jasowang@...hat.com, pbonzini@...hat.com, stefanha@...hat.com,
        eperezma@...hat.com, virtualization@...ts.linux.dev,
        kvm@...r.kernel.org
Cc: darren.kenny@...cle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vhost-scsi: Fix check for inline_sg_cnt exceeding
 preallocated limit

On 6/7/25 2:40 PM, Alok Tiwari wrote:
> The condition comparing ret to VHOST_SCSI_PREALLOC_SGLS was incorrect,
> as ret holds the result of kstrtouint() (typically 0 on success),
> not the parsed value. Update the check to use cnt, which contains the
> actual user-provided value.
> 
> prevents silently accepting values exceeding the maximum inline_sg_cnt.
> 
> Fixes: bca939d5bcd0 ("vhost-scsi: Dynamically allocate scatterlists")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
> ---
>  drivers/vhost/scsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
> index c12a0d4e6386..8d655b2d15d9 100644
> --- a/drivers/vhost/scsi.c
> +++ b/drivers/vhost/scsi.c
> @@ -71,7 +71,7 @@ static int vhost_scsi_set_inline_sg_cnt(const char *buf,
>  	if (ret)
>  		return ret;
>  
> -	if (ret > VHOST_SCSI_PREALLOC_SGLS) {
> +	if (cnt > VHOST_SCSI_PREALLOC_SGLS) {
>  		pr_err("Max inline_sg_cnt is %u\n", VHOST_SCSI_PREALLOC_SGLS);
>  		return -EINVAL;
>  	}

Thanks.

Reviewed-by: Mike Christie <michael.christie@...cle.com>