linux-kernel - Re: [PATCH v2 1/4] userfaultfd: correctly prevent registering VM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250607150438.4439e19f74693445212d93df@linux-foundation.org>
Date: Sat, 7 Jun 2025 15:04:38 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Tal Zussman <tz2294@...umbia.edu>
Cc: Peter Xu <peterx@...hat.com>, "Jason A. Donenfeld" <Jason@...c4.com>,
 David Hildenbrand <david@...hat.com>, Alexander Viro
 <viro@...iv.linux.org.uk>, Christian Brauner <brauner@...nel.org>, Jan Kara
 <jack@...e.cz>, Andrea Arcangeli <aarcange@...hat.com>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v2 1/4] userfaultfd: correctly prevent registering
 VM_DROPPABLE regions

On Sat, 07 Jun 2025 02:40:00 -0400 Tal Zussman <tz2294@...umbia.edu> wrote:

> vma_can_userfault() masks off non-userfaultfd VM flags from vm_flags.
> The vm_flags & VM_DROPPABLE test will then always be false, incorrectly
> allowing VM_DROPPABLE regions to be registered with userfaultfd.
> 
> Additionally, vm_flags is not guaranteed to correspond to the actual
> VMA's flags. Fix this test by checking the VMA's flags directly.

Wondering if we should backport this.  afaict we don't know the
userspace impact of this because nobody has tried it!