linux-kernel - [PATCH] selftests/bpf: fix signedness bug in redir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250608143623.25242-1-wangfushuai@baidu.com>
Date: Sun, 8 Jun 2025 22:36:23 +0800
From: wangfushuai <wangfushuai@...du.com>
To: <andrii@...nel.org>, <eddyz87@...il.com>, <mykolal@...com>,
	<martin.lau@...ux.dev>, <song@...nel.org>, <yonghong.song@...ux.dev>,
	<john.fastabend@...il.com>, <kpsingh@...nel.org>, <sdf@...ichev.me>,
	<haoluo@...gle.com>, <jolsa@...nel.org>
CC: <ast@...nel.org>, <daniel@...earbox.net>, <shuah@...nel.org>,
	<mhal@...x.co>, <jakub@...udflare.com>, <thinker.li@...il.com>,
	<bpf@...r.kernel.org>, <linux-kselftest@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, wangfushuai <wangfushuai@...du.com>
Subject: [PATCH] selftests/bpf: fix signedness bug in redir_partial()

When xsend() returns -1 (error), the check 'n < sizeof(buf)' incorrectly
treats it as success due to unsigned promotion. Explicitly check for -1
first.

Fixes: a4b7193d8efd ("selftests/bpf: Add sockmap test for redirecting partial skb data")
Signed-off-by: wangfushuai <wangfushuai@...du.com>
---
 tools/testing/selftests/bpf/prog_tests/sockmap_listen.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/bpf/prog_tests/sockmap_listen.c b/tools/testing/selftests/bpf/prog_tests/sockmap_listen.c
index 1d98eee7a2c3..f1bdccc7e4e7 100644
--- a/tools/testing/selftests/bpf/prog_tests/sockmap_listen.c
+++ b/tools/testing/selftests/bpf/prog_tests/sockmap_listen.c
@@ -924,6 +924,8 @@ static void redir_partial(int family, int sotype, int sock_map, int parser_map)
 		goto close;
 
 	n = xsend(c1, buf, sizeof(buf), 0);
+	if (n == -1)
+		goto close;
 	if (n < sizeof(buf))
 		FAIL("incomplete write");
 
-- 
2.36.1