| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202506090550.y3ypu2EO-lkp@intel.com>
Date: Mon, 9 Jun 2025 05:44:47 +0800
From: kernel test robot <lkp@...el.com>
To: Yury Norov <yury.norov@...il.com>, linux-kernel@...r.kernel.org,
Rasmus Villemoes <linux@...musvillemoes.dk>,
John Stultz <jstultz@...gle.com>,
Thomas Gleixner <tglx@...utronix.de>,
Stephen Boyd <sboyd@...nel.org>,
Andrew Morton <akpm@...ux-foundation.org>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
Linux Memory Management List <linux-mm@...ck.org>
Subject: Re: [PATCH 1/3] bitmap: generalize node_random()
Hi Yury,
kernel test robot noticed the following build errors:
[auto build test ERROR on akpm-mm/mm-nonmm-unstable]
[also build test ERROR on tip/timers/core akpm-mm/mm-everything linus/master v6.15 next-20250606]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Yury-Norov/bitmap-generalize-node_random/20250609-034657
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-nonmm-unstable
patch link: https://lore.kernel.org/r/20250608194536.28130-2-yury.norov%40gmail.com
patch subject: [PATCH 1/3] bitmap: generalize node_random()
config: arm-randconfig-002-20250609 (https://download.01.org/0day-ci/archive/20250609/202506090550.y3ypu2EO-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250609/202506090550.y3ypu2EO-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506090550.y3ypu2EO-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from ./arch/arm/include/generated/asm/preempt.h:1:
In file included from include/asm-generic/preempt.h:5:
In file included from include/linux/thread_info.h:27:
In file included from include/linux/bitops.h:29:
include/asm-generic/bitops/generic-non-atomic.h:140:16: warning: attribute 'error' is already applied with different arguments [-Wignored-attributes]
140 | return 1UL & (smp_load_acquire(p) >> (nr & (BITS_PER_LONG-1)));
| ^
include/asm-generic/barrier.h:204:37: note: expanded from macro 'smp_load_acquire'
204 | __unqual_scalar_typeof(*p) ___p1 = READ_ONCE(*p); \
| ^
include/asm-generic/rwonce.h:49:2: note: expanded from macro 'READ_ONCE'
49 | compiletime_assert_rwonce_type(x); \
| ^
include/asm-generic/rwonce.h:36:2: note: expanded from macro 'compiletime_assert_rwonce_type'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^
include/linux/compiler_types.h:565:2: note: expanded from macro 'compiletime_assert'
565 | __compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^
include/linux/compiler_types.h:547:4: note: expanded from macro '__compiletime_assert'
547 | __compiletime_error(msg); \
| ^
include/linux/compiler_attributes.h:138:56: note: expanded from macro '__compiletime_error'
138 | # define __compiletime_error(msg) __attribute__((__error__(msg)))
| ^
include/linux/mm.h:2618:9: note: previous attribute is here
2618 | return max(mm->hiwater_rss, get_mm_rss(mm));
| ^
include/linux/minmax.h:112:19: note: expanded from macro 'max'
112 | #define max(x, y) __careful_cmp(max, x, y)
| ^
include/linux/minmax.h:98:2: note: expanded from macro '__careful_cmp'
98 | __careful_cmp_once(op, x, y, __UNIQUE_ID(x_), __UNIQUE_ID(y_))
| ^
include/linux/minmax.h:93:2: note: expanded from macro '__careful_cmp_once'
93 | BUILD_BUG_ON_MSG(!__types_ok(ux, uy), \
| ^
note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
include/linux/compiler_types.h:565:2: note: expanded from macro 'compiletime_assert'
565 | __compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^
include/linux/compiler_types.h:547:4: note: expanded from macro '__compiletime_assert'
547 | __compiletime_error(msg); \
| ^
include/linux/compiler_attributes.h:138:56: note: expanded from macro '__compiletime_error'
138 | # define __compiletime_error(msg) __attribute__((__error__(msg)))
| ^
In file included from crypto/krb5/rfc8009_aes2.c:10:
In file included from include/linux/slab.h:16:
In file included from include/linux/gfp.h:7:
In file included from include/linux/mmzone.h:8:
In file included from include/linux/spinlock.h:56:
In file included from include/linux/preempt.h:79:
In file included from ./arch/arm/include/generated/asm/preempt.h:1:
In file included from include/asm-generic/preempt.h:5:
In file included from include/linux/thread_info.h:27:
In file included from include/linux/bitops.h:29:
include/asm-generic/bitops/generic-non-atomic.h:140:16: warning: attribute 'error' is already applied with different arguments [-Wignored-attributes]
140 | return 1UL & (smp_load_acquire(p) >> (nr & (BITS_PER_LONG-1)));
| ^
include/asm-generic/barrier.h:204:37: note: expanded from macro 'smp_load_acquire'
204 | __unqual_scalar_typeof(*p) ___p1 = READ_ONCE(*p); \
| ^
include/asm-generic/rwonce.h:49:2: note: expanded from macro 'READ_ONCE'
49 | compiletime_assert_rwonce_type(x); \
| ^
include/asm-generic/rwonce.h:36:2: note: expanded from macro 'compiletime_assert_rwonce_type'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^
include/linux/compiler_types.h:565:2: note: expanded from macro 'compiletime_assert'
565 | __compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^
include/linux/compiler_types.h:547:4: note: expanded from macro '__compiletime_assert'
547 | __compiletime_error(msg); \
| ^
include/linux/compiler_attributes.h:138:56: note: expanded from macro '__compiletime_error'
138 | # define __compiletime_error(msg) __attribute__((__error__(msg)))
| ^
include/linux/mm.h:2623:9: note: previous attribute is here
2623 | return max(mm->hiwater_vm, mm->total_vm);
| ^
include/linux/minmax.h:112:19: note: expanded from macro 'max'
112 | #define max(x, y) __careful_cmp(max, x, y)
| ^
include/linux/minmax.h:98:2: note: expanded from macro '__careful_cmp'
98 | __careful_cmp_once(op, x, y, __UNIQUE_ID(x_), __UNIQUE_ID(y_))
| ^
include/linux/minmax.h:93:2: note: expanded from macro '__careful_cmp_once'
93 | BUILD_BUG_ON_MSG(!__types_ok(ux, uy), \
| ^
note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
include/linux/compiler_types.h:565:2: note: expanded from macro 'compiletime_assert'
565 | __compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^
include/linux/compiler_types.h:547:4: note: expanded from macro '__compiletime_assert'
547 | __compiletime_error(msg); \
| ^
include/linux/compiler_attributes.h:138:56: note: expanded from macro '__compiletime_error'
138 | # define __compiletime_error(msg) __attribute__((__error__(msg)))
| ^
>> crypto/krb5/rfc8009_aes2.c:209:3: error: call to undeclared function 'get_random_bytes'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
209 | get_random_bytes(buffer, krb5->conf_len);
| ^
27 warnings and 1 error generated.
vim +/get_random_bytes +209 crypto/krb5/rfc8009_aes2.c
6c3c0e86c2acf5 David Howells 2025-02-03 167
6c3c0e86c2acf5 David Howells 2025-02-03 168 /*
6c3c0e86c2acf5 David Howells 2025-02-03 169 * Apply encryption and checksumming functions to a message. Unlike for
6c3c0e86c2acf5 David Howells 2025-02-03 170 * RFC3961, for RFC8009, we have to chuck the starting IV into the hash first.
6c3c0e86c2acf5 David Howells 2025-02-03 171 */
6c3c0e86c2acf5 David Howells 2025-02-03 172 static ssize_t rfc8009_encrypt(const struct krb5_enctype *krb5,
6c3c0e86c2acf5 David Howells 2025-02-03 173 struct crypto_aead *aead,
6c3c0e86c2acf5 David Howells 2025-02-03 174 struct scatterlist *sg, unsigned int nr_sg, size_t sg_len,
6c3c0e86c2acf5 David Howells 2025-02-03 175 size_t data_offset, size_t data_len,
6c3c0e86c2acf5 David Howells 2025-02-03 176 bool preconfounded)
6c3c0e86c2acf5 David Howells 2025-02-03 177 {
6c3c0e86c2acf5 David Howells 2025-02-03 178 struct aead_request *req;
6c3c0e86c2acf5 David Howells 2025-02-03 179 struct scatterlist bsg[2];
6c3c0e86c2acf5 David Howells 2025-02-03 180 ssize_t ret, done;
6c3c0e86c2acf5 David Howells 2025-02-03 181 size_t bsize, base_len, secure_offset, secure_len, pad_len, cksum_offset;
6c3c0e86c2acf5 David Howells 2025-02-03 182 void *buffer;
6c3c0e86c2acf5 David Howells 2025-02-03 183 u8 *iv, *ad;
6c3c0e86c2acf5 David Howells 2025-02-03 184
6c3c0e86c2acf5 David Howells 2025-02-03 185 if (WARN_ON(data_offset != krb5->conf_len))
6c3c0e86c2acf5 David Howells 2025-02-03 186 return -EINVAL; /* Data is in wrong place */
6c3c0e86c2acf5 David Howells 2025-02-03 187
6c3c0e86c2acf5 David Howells 2025-02-03 188 secure_offset = 0;
6c3c0e86c2acf5 David Howells 2025-02-03 189 base_len = krb5->conf_len + data_len;
6c3c0e86c2acf5 David Howells 2025-02-03 190 pad_len = 0;
6c3c0e86c2acf5 David Howells 2025-02-03 191 secure_len = base_len + pad_len;
6c3c0e86c2acf5 David Howells 2025-02-03 192 cksum_offset = secure_len;
6c3c0e86c2acf5 David Howells 2025-02-03 193 if (WARN_ON(cksum_offset + krb5->cksum_len > sg_len))
6c3c0e86c2acf5 David Howells 2025-02-03 194 return -EFAULT;
6c3c0e86c2acf5 David Howells 2025-02-03 195
6c3c0e86c2acf5 David Howells 2025-02-03 196 bsize = krb5_aead_size(aead) +
6c3c0e86c2acf5 David Howells 2025-02-03 197 krb5_aead_ivsize(aead) * 2;
6c3c0e86c2acf5 David Howells 2025-02-03 198 buffer = kzalloc(bsize, GFP_NOFS);
6c3c0e86c2acf5 David Howells 2025-02-03 199 if (!buffer)
6c3c0e86c2acf5 David Howells 2025-02-03 200 return -ENOMEM;
6c3c0e86c2acf5 David Howells 2025-02-03 201
6c3c0e86c2acf5 David Howells 2025-02-03 202 req = buffer;
6c3c0e86c2acf5 David Howells 2025-02-03 203 iv = buffer + krb5_aead_size(aead);
6c3c0e86c2acf5 David Howells 2025-02-03 204 ad = buffer + krb5_aead_size(aead) + krb5_aead_ivsize(aead);
6c3c0e86c2acf5 David Howells 2025-02-03 205
6c3c0e86c2acf5 David Howells 2025-02-03 206 /* Insert the confounder into the buffer */
6c3c0e86c2acf5 David Howells 2025-02-03 207 ret = -EFAULT;
6c3c0e86c2acf5 David Howells 2025-02-03 208 if (!preconfounded) {
6c3c0e86c2acf5 David Howells 2025-02-03 @209 get_random_bytes(buffer, krb5->conf_len);
6c3c0e86c2acf5 David Howells 2025-02-03 210 done = sg_pcopy_from_buffer(sg, nr_sg, buffer, krb5->conf_len,
6c3c0e86c2acf5 David Howells 2025-02-03 211 secure_offset);
6c3c0e86c2acf5 David Howells 2025-02-03 212 if (done != krb5->conf_len)
6c3c0e86c2acf5 David Howells 2025-02-03 213 goto error;
6c3c0e86c2acf5 David Howells 2025-02-03 214 }
6c3c0e86c2acf5 David Howells 2025-02-03 215
6c3c0e86c2acf5 David Howells 2025-02-03 216 /* We may need to pad out to the crypto blocksize. */
6c3c0e86c2acf5 David Howells 2025-02-03 217 if (pad_len) {
6c3c0e86c2acf5 David Howells 2025-02-03 218 done = sg_zero_buffer(sg, nr_sg, pad_len, data_offset + data_len);
6c3c0e86c2acf5 David Howells 2025-02-03 219 if (done != pad_len)
6c3c0e86c2acf5 David Howells 2025-02-03 220 goto error;
6c3c0e86c2acf5 David Howells 2025-02-03 221 }
6c3c0e86c2acf5 David Howells 2025-02-03 222
6c3c0e86c2acf5 David Howells 2025-02-03 223 /* We need to include the starting IV in the hash. */
6c3c0e86c2acf5 David Howells 2025-02-03 224 sg_init_table(bsg, 2);
6c3c0e86c2acf5 David Howells 2025-02-03 225 sg_set_buf(&bsg[0], ad, krb5_aead_ivsize(aead));
6c3c0e86c2acf5 David Howells 2025-02-03 226 sg_chain(bsg, 2, sg);
6c3c0e86c2acf5 David Howells 2025-02-03 227
6c3c0e86c2acf5 David Howells 2025-02-03 228 /* Hash and encrypt the message. */
6c3c0e86c2acf5 David Howells 2025-02-03 229 aead_request_set_tfm(req, aead);
6c3c0e86c2acf5 David Howells 2025-02-03 230 aead_request_set_callback(req, 0, NULL, NULL);
6c3c0e86c2acf5 David Howells 2025-02-03 231 aead_request_set_ad(req, krb5_aead_ivsize(aead));
6c3c0e86c2acf5 David Howells 2025-02-03 232 aead_request_set_crypt(req, bsg, bsg, secure_len, iv);
6c3c0e86c2acf5 David Howells 2025-02-03 233 ret = crypto_aead_encrypt(req);
6c3c0e86c2acf5 David Howells 2025-02-03 234 if (ret < 0)
6c3c0e86c2acf5 David Howells 2025-02-03 235 goto error;
6c3c0e86c2acf5 David Howells 2025-02-03 236
6c3c0e86c2acf5 David Howells 2025-02-03 237 ret = secure_len + krb5->cksum_len;
6c3c0e86c2acf5 David Howells 2025-02-03 238
6c3c0e86c2acf5 David Howells 2025-02-03 239 error:
6c3c0e86c2acf5 David Howells 2025-02-03 240 kfree_sensitive(buffer);
6c3c0e86c2acf5 David Howells 2025-02-03 241 return ret;
6c3c0e86c2acf5 David Howells 2025-02-03 242 }
6c3c0e86c2acf5 David Howells 2025-02-03 243
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists