linux-kernel - Re: [PATCH v5 20/29] x86,fs/resctrl: Fill in details of Clearwater Forest events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aEYJD8OUis3O1Tdd@agluck-desk3>
Date: Sun, 8 Jun 2025 15:05:03 -0700
From: "Luck, Tony" <tony.luck@...el.com>
To: Fenghua Yu <fenghuay@...dia.com>
Cc: Reinette Chatre <reinette.chatre@...el.com>,
	Maciej Wieczor-Retman <maciej.wieczor-retman@...el.com>,
	Peter Newman <peternewman@...gle.com>,
	James Morse <james.morse@....com>, Babu Moger <babu.moger@....com>,
	Drew Fustini <dfustini@...libre.com>,
	Dave Martin <Dave.Martin@....com>,
	Anil Keshavamurthy <anil.s.keshavamurthy@...el.com>,
	Chen Yu <yu.c.chen@...el.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, patches@...ts.linux.dev
Subject: Re: [PATCH v5 20/29] x86,fs/resctrl: Fill in details of Clearwater
 Forest events

On Fri, Jun 06, 2025 at 05:57:09PM -0700, Fenghua Yu wrote:
> > @@ -60,6 +78,11 @@ struct event_group {
> >   static struct event_group energy_0x26696143 = {
> >   	.guid		= 0x26696143,
> >   	.mmio_size	= (576 * 2 + 3) * 8,
> > +	.num_events	= 2,
> > +	.evts				= {
> Please align the "=" with the above "=".

Fixed.

> > +		EVT(PMT_EVENT_ENERGY, 0, 18),
> > +		EVT(PMT_EVENT_ACTIVITY, 1, 18),
> > +	}
> >   };
> >   /*
> > @@ -69,6 +92,16 @@ static struct event_group energy_0x26696143 = {
> >   static struct event_group perf_0x26557651 = {
> >   	.guid		= 0x26557651,
> >   	.mmio_size	= (576 * 7 + 3) * 8,
> > +	.num_events	= 7,
> > +	.evts				= {
> 
> Ditto.

Ditto fixed.

Thanks

-Tony