linux-kernel - Re: [PATCH] crypto: inside-secure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250608234119.GC1259@sol>
Date: Sun, 8 Jun 2025 16:41:19 -0700
From: Eric Biggers <ebiggers@...nel.org>
To: linux-kernel@...r.kernel.org
Cc: linux-crypto@...r.kernel.org, Ard Biesheuvel <ardb@...nel.org>,
	Antoine Tenart <atenart@...nel.org>
Subject: Re: [PATCH] crypto: inside-secure - remove crc32 support

On Sat, May 31, 2025 at 01:42:44PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> The crc32 acceleration in the inside-secure driver is accessible only as
> an asynchronous hash.  However, there seems to be no corresponding user
> of crc32 in the kernel that supports asynchronous hashes.  Therefore,
> this code seems to be unused.
> 
> The patch that added this code provided no justification for its
> inclusion.  All devicetree bindings for this accelerator are for arm64;
> arm64 CPUs often have CRC or PMULL instructions, which already
> accelerate crc32 very well.  And these actually work with the crc32
> users in the kernel, unlike this driver which doesn't.
> 
> Remove this unnecessary code.
> 
> Cc: Antoine Tenart <atenart@...nel.org>
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> ---
> 
> I'm planning to take this patch via the crc tree.
> 
>  drivers/crypto/inside-secure/safexcel.c      |  1 -
>  drivers/crypto/inside-secure/safexcel.h      |  1 -
>  drivers/crypto/inside-secure/safexcel_hash.c | 92 +-------------------
>  3 files changed, 2 insertions(+), 92 deletions(-)

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=crc-next

- Eric