linux-kernel - [PATCH 0/4] smb/server: various clean-ups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250608234108.30250-1-neil@brown.name>
Date: Mon,  9 Jun 2025 09:35:06 +1000
From: NeilBrown <neil@...wn.name>
To: Namjae Jeon <linkinjeon@...nel.org>,
	Steve French <smfrench@...il.com>,
	Sergey Senozhatsky <senozhatsky@...omium.org>,
	Tom Talpey <tom@...pey.com>
Cc: Alexander Viro <viro@...iv.linux.org.uk>,
	Christian Brauner <brauner@...nel.org>,
	Jan Kara <jack@...e.cz>,
	linux-fsdevel@...r.kernel.org,
	linux-cifs@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH 0/4] smb/server: various clean-ups

I am working towards making some changes to how locking is managed for
directory operations.  Prior to attempting to land these changes I am
reviewing code that requests directory operations and cleaning up things
that might cause me problems later.

These 4 patches are the result of my review of smb/server.  Note that
patch 3 fixes what appears to be a real deadlock that should be trivial
to hit if the client can actually set the flag which, as mentioned in
the patch, can trigger the deadlock.

Patch 1 is trivial but the others deserve careful review by someone who
knows the code.  I think they are correct, but I've been wrong before.

Thanks,
NeilBrown

 [PATCH 1/4] smb/server: use lookup_one_unlocked()
 [PATCH 2/4] smb/server: simplify ksmbd_vfs_kern_path_locked()
 [PATCH 3/4] smb/server: avoid deadlock when linking with
 [PATCH 4/4] smb/server: add ksmbd_vfs_kern_path()