lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202506090720.YHNaPWqT-lkp@intel.com>
Date: Mon, 9 Jun 2025 07:58:59 +0800
From: kernel test robot <lkp@...el.com>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: arch/mips/txx9/generic/setup.c:837:32: error: assignment to 'ssize_t
 (*)(struct file *, struct kobject *, const struct bin_attribute *, char *,
 loff_t,  size_t)' {aka 'int (*)(struct file *, struct kobject *, const
 struct bin_attribute *, char *, long lon...

Hi Thomas,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   19272b37aa4f83ca52bdf9c16d5d81bdd1354494
commit: 97d06802d10a2827ef46fd31789a26117ce7f3d9 sysfs: constify bin_attribute argument of bin_attribute::read/write()
date:   8 weeks ago
config: mips-rbtx49xx_defconfig (https://download.01.org/0day-ci/archive/20250609/202506090720.YHNaPWqT-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250609/202506090720.YHNaPWqT-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506090720.YHNaPWqT-lkp@intel.com/

All errors (new ones prefixed by >>):

   arch/mips/txx9/generic/setup.c: In function 'txx9_sramc_init':
>> arch/mips/txx9/generic/setup.c:837:32: error: assignment to 'ssize_t (*)(struct file *, struct kobject *, const struct bin_attribute *, char *, loff_t,  size_t)' {aka 'int (*)(struct file *, struct kobject *, const struct bin_attribute *, char *, long long int,  unsigned int)'} from incompatible pointer type 'ssize_t (*)(struct file *, struct kobject *, struct bin_attribute *, char *, loff_t,  size_t)' {aka 'int (*)(struct file *, struct kobject *, struct bin_attribute *, char *, long long int,  unsigned int)'} [-Wincompatible-pointer-types]
     837 |         dev->bindata_attr.read = txx9_sram_read;
         |                                ^
   arch/mips/txx9/generic/setup.c:776:16: note: 'txx9_sram_read' declared here
     776 | static ssize_t txx9_sram_read(struct file *filp, struct kobject *kobj,
         |                ^~~~~~~~~~~~~~
   arch/mips/txx9/generic/setup.c:838:33: error: assignment to 'ssize_t (*)(struct file *, struct kobject *, const struct bin_attribute *, char *, loff_t,  size_t)' {aka 'int (*)(struct file *, struct kobject *, const struct bin_attribute *, char *, long long int,  unsigned int)'} from incompatible pointer type 'ssize_t (*)(struct file *, struct kobject *, struct bin_attribute *, char *, loff_t,  size_t)' {aka 'int (*)(struct file *, struct kobject *, struct bin_attribute *, char *, long long int,  unsigned int)'} [-Wincompatible-pointer-types]
     838 |         dev->bindata_attr.write = txx9_sram_write;
         |                                 ^
   arch/mips/txx9/generic/setup.c:791:16: note: 'txx9_sram_write' declared here
     791 | static ssize_t txx9_sram_write(struct file *filp, struct kobject *kobj,
         |                ^~~~~~~~~~~~~~~


vim +837 arch/mips/txx9/generic/setup.c

1610c8a8f2d3eb Levente Kurusa 2013-12-19  813  
c3b28ae260d99a Atsushi Nemoto 2009-05-25  814  void __init txx9_sramc_init(struct resource *r)
c3b28ae260d99a Atsushi Nemoto 2009-05-25  815  {
269a3eb1bf10a0 Kay Sievers    2011-12-21  816  	struct txx9_sramc_dev *dev;
c3b28ae260d99a Atsushi Nemoto 2009-05-25  817  	size_t size;
c3b28ae260d99a Atsushi Nemoto 2009-05-25  818  	int err;
c3b28ae260d99a Atsushi Nemoto 2009-05-25  819  
269a3eb1bf10a0 Kay Sievers    2011-12-21  820  	err = subsys_system_register(&txx9_sramc_subsys, NULL);
269a3eb1bf10a0 Kay Sievers    2011-12-21  821  	if (err)
c3b28ae260d99a Atsushi Nemoto 2009-05-25  822  		return;
c3b28ae260d99a Atsushi Nemoto 2009-05-25  823  	dev = kzalloc(sizeof(*dev), GFP_KERNEL);
c3b28ae260d99a Atsushi Nemoto 2009-05-25  824  	if (!dev)
c3b28ae260d99a Atsushi Nemoto 2009-05-25  825  		return;
c3b28ae260d99a Atsushi Nemoto 2009-05-25  826  	size = resource_size(r);
c3b28ae260d99a Atsushi Nemoto 2009-05-25  827  	dev->base = ioremap(r->start, size);
1610c8a8f2d3eb Levente Kurusa 2013-12-19  828  	if (!dev->base) {
1610c8a8f2d3eb Levente Kurusa 2013-12-19  829  		kfree(dev);
1610c8a8f2d3eb Levente Kurusa 2013-12-19  830  		return;
1610c8a8f2d3eb Levente Kurusa 2013-12-19  831  	}
1610c8a8f2d3eb Levente Kurusa 2013-12-19  832  	dev->dev.release = &txx9_device_release;
269a3eb1bf10a0 Kay Sievers    2011-12-21  833  	dev->dev.bus = &txx9_sramc_subsys;
f937331b3f92cb Wolfram Sang   2010-03-15  834  	sysfs_bin_attr_init(&dev->bindata_attr);
c3b28ae260d99a Atsushi Nemoto 2009-05-25  835  	dev->bindata_attr.attr.name = "bindata";
c3b28ae260d99a Atsushi Nemoto 2009-05-25  836  	dev->bindata_attr.attr.mode = S_IRUSR | S_IWUSR;
c3b28ae260d99a Atsushi Nemoto 2009-05-25 @837  	dev->bindata_attr.read = txx9_sram_read;

:::::: The code at line 837 was first introduced by commit
:::::: c3b28ae260d99a5364a31210a36a3246bd9647f7 MIPS: TXx9: Add SRAMC support

:::::: TO: Atsushi Nemoto <anemo@....ocn.ne.jp>
:::::: CC: Ralf Baechle <ralf@...ux-mips.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ