linux-kernel - Re: [RFC v2 08/16] luo: luo_files: add infrastructure for FDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CA+CK2bDJ6eYrVh4qewzH63HUUwKwGjcw=e8NhTF5AQ3f3N01cg@mail.gmail.com>
Date: Sat, 7 Jun 2025 20:07:00 -0400
From: Pasha Tatashin <pasha.tatashin@...een.com>
To: Anish Moorthy <anish.moorthy@...il.com>
Cc: Jonathan.Cameron@...wei.com, akpm@...ux-foundation.org, 
	aleksander.lobakin@...el.com, aliceryhl@...gle.com, 
	andriy.shevchenko@...ux.intel.com, anna.schumaker@...cle.com, axboe@...nel.dk, 
	bartosz.golaszewski@...aro.org, bhelgaas@...gle.com, bp@...en8.de, 
	changyuanl@...gle.com, chenridong@...wei.com, corbet@....net, 
	cw00.choi@...sung.com, dakr@...nel.org, dan.j.williams@...el.com, 
	dave.hansen@...ux.intel.com, david@...hat.com, djeffery@...hat.com, 
	dmatlack@...gle.com, graf@...zon.com, gregkh@...uxfoundation.org, 
	hannes@...xchg.org, hpa@...or.com, ilpo.jarvinen@...ux.intel.com, 
	ira.weiny@...el.com, jannh@...gle.com, jasonmiu@...gle.com, 
	joel.granados@...nel.org, kanie@...ux.alibaba.com, leon@...nel.org, 
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, linux-mm@...ck.org, 
	linux@...ssschuh.net, lukas@...ner.de, mark.rutland@....com, 
	masahiroy@...nel.org, mingo@...hat.com, mmaurer@...gle.com, 
	myungjoo.ham@...sung.com, ojeda@...nel.org, pratyush@...nel.org, 
	ptyadav@...zon.de, quic_zijuhu@...cinc.com, rafael@...nel.org, 
	rdunlap@...radead.org, rientjes@...gle.com, roman.gushchin@...ux.dev, 
	rostedt@...dmis.org, rppt@...nel.org, song@...nel.org, 
	stuart.w.hayes@...il.com, tglx@...utronix.de, tj@...nel.org, 
	vincent.guittot@...aro.org, wagi@...nel.org, x86@...nel.org, 
	yesanishhere@...il.com, yoann.congal@...le.fr, zhangguopeng@...inos.cn
Subject: Re: [RFC v2 08/16] luo: luo_files: add infrastructure for FDs

On Fri, Jun 6, 2025 at 6:28 PM Anish Moorthy <anish.moorthy@...il.com> wrote:
>
> > + token = luo_next_file_token;
> > + luo_next_file_token++;
>
> This seems like it should be an atomic fetch_add: I'm only seeing read locks up till this point
>
> (Sorry if this is too nitpicky. Also for any formatting issues, I'm on mobile atm)

Thank you, this was also found by other reviewers. I have updated this
to use atomic.

Pasha