linux-kernel - Re: [PATCH v2 1/2] x86/mm: Handle alloc failure in phys_*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202506100135.4iTfYLoH-lkp@intel.com>
Date: Tue, 10 Jun 2025 01:56:40 +0800
From: kernel test robot <lkp@...el.com>
To: Em Sharnoff <sharnoff@...n.tech>, linux-kernel@...r.kernel.org,
	x86@...nel.org, linux-mm@...ck.org
Cc: oe-kbuild-all@...ts.linux.dev, Ingo Molnar <mingo@...nel.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Andy Lutomirski <luto@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Borislav Petkov <bp@...en8.de>,
	"Edgecombe, Rick P" <rick.p.edgecombe@...el.com>,
	Oleg Vasilev <oleg@...n.tech>,
	Arthur Petukhovsky <arthur@...n.tech>,
	Stefan Radig <stefan@...n.tech>, Misha Sakhnov <misha@...n.tech>
Subject: Re: [PATCH v2 1/2] x86/mm: Handle alloc failure in phys_*_init()

Hi Em,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 82f2b0b97b36ee3fcddf0f0780a9a0825d52fec3]

url:    https://github.com/intel-lab-lkp/linux/commits/Em-Sharnoff/x86-mm-Handle-alloc-failure-in-phys_-_init/20250609-183537
base:   82f2b0b97b36ee3fcddf0f0780a9a0825d52fec3
patch link:    https://lore.kernel.org/r/25c5e747-107f-4450-8eb0-11b2f0dab14d%40neon.tech
patch subject: [PATCH v2 1/2] x86/mm: Handle alloc failure in phys_*_init()
config: i386-buildonly-randconfig-006-20250609 (https://download.01.org/0day-ci/archive/20250610/202506100135.4iTfYLoH-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250610/202506100135.4iTfYLoH-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506100135.4iTfYLoH-lkp@intel.com/

All warnings (new ones prefixed by >>):

   arch/x86/mm/init.c: In function 'init_memory_mapping':
>> arch/x86/mm/init.c:555:28: warning: passing argument 1 of 'IS_ERR' makes pointer from integer without a cast [-Wint-conversion]
     555 |                 if (IS_ERR(ret))
         |                            ^~~
         |                            |
         |                            long unsigned int
   In file included from include/linux/string.h:11,
                    from arch/x86/include/asm/page_32.h:18,
                    from arch/x86/include/asm/page.h:14,
                    from arch/x86/include/asm/thread_info.h:12,
                    from include/linux/thread_info.h:60,
                    from include/linux/spinlock.h:60,
                    from include/linux/mmzone.h:8,
                    from include/linux/gfp.h:7,
                    from arch/x86/mm/init.c:1:
   include/linux/err.h:68:60: note: expected 'const void *' but argument is of type 'long unsigned int'
      68 | static inline bool __must_check IS_ERR(__force const void *ptr)
         |                                                ~~~~~~~~~~~~^~~


vim +/IS_ERR +555 arch/x86/mm/init.c

   531	
   532	/*
   533	 * Setup the direct mapping of the physical memory at PAGE_OFFSET.
   534	 * This runs before bootmem is initialized and gets pages directly from
   535	 * the physical memory. To access them they are temporarily mapped.
   536	 * Allocation errors are returned with ERR_PTR.
   537	 */
   538	unsigned long __ref init_memory_mapping(unsigned long start,
   539						unsigned long end, pgprot_t prot)
   540	{
   541		struct map_range mr[NR_RANGE_MR];
   542		unsigned long ret = 0;
   543		int nr_range, i;
   544	
   545		pr_debug("init_memory_mapping: [mem %#010lx-%#010lx]\n",
   546		       start, end - 1);
   547	
   548		memset(mr, 0, sizeof(mr));
   549		nr_range = split_mem_range(mr, 0, start, end);
   550	
   551		for (i = 0; i < nr_range; i++) {
   552			ret = kernel_physical_mapping_init(mr[i].start, mr[i].end,
   553							   mr[i].page_size_mask,
   554							   prot);
 > 555			if (IS_ERR(ret))
   556				return ret;
   557		}
   558	
   559		add_pfn_range_mapped(start >> PAGE_SHIFT, ret >> PAGE_SHIFT);
   560	
   561		return ret >> PAGE_SHIFT;
   562	}
   563	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki