linux-kernel - Re: [PATCH v2 1/5] arm: dts: omap: Remove incorrect compatible strings from device trees

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250609223516.32ec18be@kmaincent-XPS-13-7390>
Date: Mon, 9 Jun 2025 22:35:16 +0200
From: Kory Maincent <kory.maincent@...tlin.com>
To: Andreas Kemnade <andreas@...nade.info>
Cc: Tony Lindgren <tony@...mide.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Aaro Koskinen <aaro.koskinen@....fi>, Kevin Hilman
 <khilman@...libre.com>, Roger Quadros <rogerq@...nel.org>, Russell King
 <linux@...linux.org.uk>, Bajjuri Praneeth <praneeth@...com>, Liam Girdwood
 <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>, linux-omap@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 1/5] arm: dts: omap: Remove incorrect compatible
 strings from device trees

Le Mon, 9 Jun 2025 22:08:09 +0200,
Andreas Kemnade <andreas@...nade.info> a écrit :

> Am Mon, 09 Jun 2025 17:43:51 +0200
> schrieb Kory Maincent <kory.maincent@...tlin.com>:
> 
> > Several device trees incorrectly included ti,am335x-bone-black or
> > ti,am335x-bone in their compatible lists without including the
> > corresponding bone-black-common or bone-common device tree files.
> > Remove these incompatible strings to fix the inconsistency.
> >   
> thanks for cleaning up some mess.
> 
> > Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>
> > ---
> > 
> > Change in v2:
> > - New patch
> > ---
> >  arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts | 2 +-
> >  arch/arm/boot/dts/ti/omap/am335x-bonegreen.dts          | 2 +-
> >  arch/arm/boot/dts/ti/omap/am335x-osd3358-sm-red.dts     | 2 +-
> >  arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts       | 2 +-
> >  arch/arm/boot/dts/ti/omap/am335x-shc.dts                | 2 +-
> >  5 files changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts
> > b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts index
> > a4f5b5262645..fb88eebb8c5d 100644 ---
> > a/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts +++
> > b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-wireless.dts @@ -11,7 +11,7 @@
> >  
> >  / {
> >  	model = "TI AM335x BeagleBone Green Wireless";
> > -	compatible = "ti,am335x-bone-green-wireless",
> > "ti,am335x-bone-green", "ti,am335x-bone-black", "ti,am335x-bone",
> > "ti,am33xx";
> > +	compatible = "ti,am335x-bone-green-wireless", "ti,am335x-bone",
> > "ti,am33xx"; 
> this looks like too much cleanup, also according your omap.yaml stuff,
> ti,am335x-bone-green should still be included.

Oh indeed! Thanks.

-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com