linux-kernel - Re: [PATCH net-next v2] net: macb: Add shutdown operation support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250609142027.25d1e58c@kernel.org>
Date: Mon, 9 Jun 2025 14:20:27 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Abin Joseph <abin.joseph@....com>
Cc: <nicolas.ferre@...rochip.com>, <claudiu.beznea@...on.dev>,
 <andrew+netdev@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
 <pabeni@...hat.com>, <git@....com>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2] net: macb: Add shutdown operation support

On Sat, 7 Jun 2025 13:27:13 +0530 Abin Joseph wrote:
> +	rtnl_lock();
> +	netif_device_detach(netdev);
> +
> +	if (netif_running(netdev))
> +		dev_close(netdev);
> +
> +	rtnl_unlock();

nit: could you move the netif_device_detach() after
the dev_close() call? It feels a little backwards, even
tho I think it will work just fine with current code.
Also nit2: you added an empty line before the unlock
but not after lock?
-- 
pw-bot: cr