linux-kernel - Re: [PATCH v2 4/5] arm: dts: omap: Add support for BeagleBone Green Eco board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250609232337.34cef4c7@akair>
Date: Mon, 9 Jun 2025 23:23:37 +0200
From: Andreas Kemnade <andreas@...nade.info>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: Conor Dooley <conor@...nel.org>, Tony Lindgren <tony@...mide.com>, Rob
 Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
 Dooley <conor+dt@...nel.org>, Aaro Koskinen <aaro.koskinen@....fi>, Kevin
 Hilman <khilman@...libre.com>, Roger Quadros <rogerq@...nel.org>, Russell
 King <linux@...linux.org.uk>, Bajjuri Praneeth <praneeth@...com>, Liam
 Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Thomas
 Petazzoni <thomas.petazzoni@...tlin.com>, linux-omap@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 4/5] arm: dts: omap: Add support for BeagleBone Green
 Eco board

Am Mon, 9 Jun 2025 22:45:02 +0200
schrieb Kory Maincent <kory.maincent@...tlin.com>:

> Le Mon, 9 Jun 2025 18:04:01 +0100,
> Conor Dooley <conor@...nel.org> a écrit :
> 
> > On Mon, Jun 09, 2025 at 05:43:54PM +0200, Kory Maincent wrote:  
> > > SeeedStudio BeagleBone Green Eco (BBGE) is a clone of the BeagleBone Green
> > > (BBG). It has minor differences from the BBG, such as a different PMIC,
> > > a different Ethernet PHY, and a larger eMMC.
> > > 
> > > Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>
> > > ---
> > > 
> > > Changes in v2:
> > > - Used generic pmic node name.
> > > - Add regulator prefix to fixed regulator node name.
> > > - Add the compatible to omap.yaml binding
> > > ---
> > >  Documentation/devicetree/bindings/arm/ti/omap.yaml |   1 +
> > >  arch/arm/boot/dts/ti/omap/Makefile                 |   1 +
> > >  arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts | 170
> > > +++++++++++++++++++++ 3 files changed, 172 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > > b/Documentation/devicetree/bindings/arm/ti/omap.yaml index
> > > c43fa4f4af81..774c13157caa 100644 ---
> > > a/Documentation/devicetree/bindings/arm/ti/omap.yaml +++
> > > b/Documentation/devicetree/bindings/arm/ti/omap.yaml @@ -145,6 +145,7 @@
> > > properties:
> > >        - description: TI bone green variants based on TI AM335
> > >          items:
> > >            - enum:
> > > +              - ti,am335x-bone-green-eco
> > >                - ti,am335x-bone-green-wireless
> > >            - const: ti,am335x-bone-green
> > >            - const: ti,am335x-bone    
> > 
> > Why is this hunk here?  
> 
> Do you mean that the binding change should be in another patch?
> 
Usually binding changes are in a separate patch. Maybe you can merge it
with Patch 2. The lonely enum looks a bit strange there, so if these
things are merged, it will look more natural.

Regards,
Andreas