linux-kernel - Re: [PATCH v6 01/11] mtd: core: always create master device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1176847729.134356549.1749504429656.JavaMail.zimbra@nod.at>
Date: Mon, 9 Jun 2025 23:27:09 +0200 (CEST)
From: Richard Weinberger <richard@....at>
To: Guenter Roeck <linux@...ck-us.net>, 
	Alexander Usyskin <alexander.usyskin@...el.com>
Cc: Miquel Raynal <miquel.raynal@...tlin.com>, 
	Vignesh Raghavendra <vigneshr@...com>, 
	Lucas De Marchi <lucas.demarchi@...el.com>, 
	Thomas Hellström <thomas.hellstrom@...ux.intel.com>, 
	Rodrigo Vivi <rodrigo.vivi@...el.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
	Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, 
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	Jani Nikula <jani.nikula@...ux.intel.com>, 
	Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>, 
	Tvrtko Ursulin <tursulin@...ulin.net>, 
	Karthik Poosa <karthik.poosa@...el.com>, 
	Reuven Abliyev <reuven.abliyev@...el.com>, 
	Oren Weil <oren.jer.weil@...el.com>, 
	linux-mtd <linux-mtd@...ts.infradead.org>, 
	DRI mailing list <dri-devel@...ts.freedesktop.org>, 
	intel-gfx <intel-gfx@...ts.freedesktop.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 01/11] mtd: core: always create master device

----- Ursprüngliche Mail -----
> Von: "Guenter Roeck" <linux@...ck-us.net>
>>> I am trying to boot from "pnor". It looks like the partition data (from
>>> devicetree)
>>> is now ignored. mtdblock6 used to be the second flash.
>>>
>>> Guenter
>> 
>> Is this with CONFIG_MTD_PARTITIONED_MASTER?
>> 
> 
> Yes
> 
>> I think that mtd_is_partition is ambiguous now.
>> We always have master partition when CONFIG_MTD_PARTITIONED_MASTER
>> is enabled and parent check is useless.
>> We must check grandparent in this case.
>> Miquel, am I right?
>> 
>> We can return to older patch version that have created partition
>> instead of the master device.
>> Or try to fix mtd_is_partition, like below.
>> Guenter, is below patch helps?
>> 
> No, it does not make a difference. Partitions are still not created.

Looks like all partition parsing is broken when CONFIG_MTD_PARTITIONED_MASTER=y is set.
Alexander, I was able to reproduce with MTDRAM and the mtdparts= kernel parameter.
Build with CONFIG_MTD_MTDRAM=y and CONFIG_MTD_PARTITIONED_MASTER=y,
pass mtdparts=\"mtdram test device:256k(foo)ro,-(bar)\" to the kernel command line.

Before your change:
$ cat /proc/mtd 
dev:    size   erasesize  name
mtd0: 00400000 00020000 "mtdram test device"
mtd1: 00040000 00020000 "foo"
mtd2: 003c0000 00020000 "bar"

After:
$ cat /proc/mtd
dev:    size   erasesize  name
mtd0: 00400000 00020000 "mtdram test device"

Hope this helps!

Thanks,
//richard