linux-kernel - Re: [PATCH v8 2/2] hwmon: (pmbus/tps53679) Add support for TPS53685

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <156dc4d6-071b-4cc5-bea9-4579c140b2f9@roeck-us.net>
Date: Mon, 9 Jun 2025 14:44:47 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Chiang Brian <chiang.brian@...entec.com>
Cc: Jean Delvare <jdelvare@...e.com>, Jonathan Corbet <corbet@....net>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>,
	linux-hwmon@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v8 2/2] hwmon: (pmbus/tps53679) Add support for TPS53685

On Mon, Jun 02, 2025 at 12:24:54PM +0800, Chiang Brian wrote:
> The TPS53685 is a fully AMD SVI3 compliant step down
> controller with trans-inductor voltage regulator
> (TLVR) topology support, dual channels, built-in
> non-volatile memory (NVM), PMBus interface, and
> full compatible with TI NexFET smart power
> stages.
> Add support for it to the tps53679 driver.
> 
> Signed-off-by: Chiang Brian <chiang.brian@...entec.com>

I was not copied on the first patch os the series, so I guess the idea
is that it is applied through a devicetree branch.
Ok, with me, but I get

CHECK: Alignment should match open parenthesis
#260: FILE: drivers/hwmon/pmbus/tps53679.c:151:
+static int tps53685_identify(struct i2c_client *client,
+				 struct pmbus_driver_info *info)

WARNING: DT compatible string "ti,tps53685" appears un-documented -- check ./Documentation/devicetree/bindings/
#295: FILE: drivers/hwmon/pmbus/tps53679.c:316:
+	{.compatible = "ti,tps53685", .data = (void *)tps53685},

That means I'll have to wait until the deveicetree patch is available.

Other than that, please fix the alignment and, while at it, reduce the
number of lines in the description. Line breaks should be at ~75 columns,
not ~50 columns.

Thanks,
Guenter