[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <87ecvs8t4g.fsf@trenco.lwn.net>
Date: Mon, 09 Jun 2025 16:09:19 -0600
From: Jonathan Corbet <corbet@....net>
To: Swapnil Sapkal <swapnil.sapkal@....com>, peterz@...radead.org
Cc: kprateek.nayak@....com, gautham.shenoy@....com,
linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
swapnil.sapkal@....com, Shrikanth Hegde <sshegde@...ux.ibm.com>
Subject: Re: [PATCH] docs/sched: Make the sched-stats documentation consistent
Swapnil Sapkal <swapnil.sapkal@....com> writes:
> pull_task(), the original function to move the task from src_rq to the
> dst_rq during load balancing was renamed to move_tasks() in commit
> ddcdf6e7d991 ("sched: Rename load-balancing fields")
>
> As a part of commit 163122b7fcfa ("sched/fair: Remove
> double_lock_balance() from load_balance()"), move_task() was broken down
> into detach_tasks() and attach_tasks() pair to avoid holding locks of
> both src_rq and dst_rq at the same time during load balancing.
>
> Despite the evolution of pull_task() over the years, the sched-stats
> documentation remained unchanged. Update the documentation to refer to
> detach_task() instead of pull_task() which is responsible for removing
> the task from the src_rq during load balancing.
>
> commit 1c055a0f5d3b ("sched: Move sched domain name out of
> CONFIG_SCHED_DEBUG") moves sched domain name out of CONFIG_SCHED_DEBUG.
> Update the documentation related to that.
>
> Reviewed-by: K Prateek Nayak <kprateek.nayak@....com>
> Suggested-by: Shrikanth Hegde <sshegde@...ux.ibm.com>
> Signed-off-by: Swapnil Sapkal <swapnil.sapkal@....com>
> ---
> Documentation/scheduler/sched-stats.rst | 53 +++++++++++++++----------
> 1 file changed, 31 insertions(+), 22 deletions(-)
It looks like this never got picked up; I've applied it now.
Thanks,
jon
Powered by blists - more mailing lists