linux-kernel - Re: [PATCH 5/5] Change vfs_mkdir() to unlock on failure.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250609053442.GC299672@ZenIV>
Date: Mon, 9 Jun 2025 06:34:42 +0100
From: Al Viro <viro@...iv.linux.org.uk>
To: NeilBrown <neil@...wn.name>
Cc: Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
	Chuck Lever <chuck.lever@...cle.com>,
	Jeff Layton <jlayton@...nel.org>,
	Amir Goldstein <amir73il@...il.com>,
	Jan Harkes <jaharkes@...cmu.edu>,
	David Howells <dhowells@...hat.com>, Tyler Hicks <code@...icks.com>,
	Miklos Szeredi <miklos@...redi.hu>,
	Carlos Maiolino <cem@...nel.org>, linux-fsdevel@...r.kernel.org,
	coda@...cmu.edu, codalist@...a.cs.cmu.edu,
	linux-nfs@...r.kernel.org, netfs@...ts.linux.dev,
	ecryptfs@...r.kernel.org, linux-unionfs@...r.kernel.org,
	linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] Change vfs_mkdir() to unlock on failure.

On Mon, Jun 09, 2025 at 03:22:00PM +1000, NeilBrown wrote:
> On Mon, 09 Jun 2025, Al Viro wrote:
> > On Mon, Jun 09, 2025 at 09:09:37AM +1000, NeilBrown wrote:
> > > Proposed changes to directory-op locking will lock the dentry rather
> > > than the whole directory.  So the dentry will need to be unlocked.
> > 
> > Please, repost your current proposal _before_ that one goes anywhere.
> > 
> 
> I've posted my proposal for the new API.  This makes the value of the
> vfs_mkdir() change clear (I hope).
> 
> Would you also like me to post the patches which introduce the new
> locking scheme?

Yes, seeing that the rest does not make much sense without that.

I would really like a description of that locking scheme as well,
TBH, but if you prefer to start with the patches, then so be it.

I can't promise a response tonight - going down in an hour or so
and I'd like to do enough reordering of #work.mount to be able
to post the initial variant of at least some of that in the
morning...