linux-kernel - Re: [PATCH v2] net: qrtr: mhi: synchronize qrtr and mhi preparation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250609160042.7a8940d7@kernel.org>
Date: Mon, 9 Jun 2025 16:00:42 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Chris Lew <chris.lew@....qualcomm.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Hemant Kumar
 <quic_hemantk@...cinc.com>, Maxim Kochetkov <fido_max@...ox.ru>, Loic
 Poulain <loic.poulain@....qualcomm.com>, Manivannan Sadhasivam
 <mani@...nel.org>, linux-arm-msm@...r.kernel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, Johan Hovold <johan@...nel.org>
Subject: Re: [PATCH v2] net: qrtr: mhi: synchronize qrtr and mhi preparation

On Wed, 04 Jun 2025 14:05:42 -0700 Chris Lew wrote:
> +	rc = qrtr_mhi_queue_rx(qdev);
> +	if (rc) {
> +		qrtr_endpoint_unregister(&qdev->ep);
> +		mhi_unprepare_from_transfer(mhi_dev);

is ignoring the rc here intentional? may be worth a comment

> +	}
> +
>  	dev_dbg(qdev->dev, "Qualcomm MHI QRTR driver probed\n");
>  
>  	return 0;

Note that we return 0 here, not rc
-- 
pw-bot: cr