linux-kernel - Re: [PATCH v2 1/2] Bluetooth: btrtl: Firmware format v3 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202506100621.JeEJ7e7X-lkp@intel.com>
Date: Tue, 10 Jun 2025 07:12:37 +0800
From: kernel test robot <lkp@...el.com>
To: Hilda Wu <hildawu@...ltek.com>, marcel@...tmann.org
Cc: oe-kbuild-all@...ts.linux.dev, luiz.dentz@...il.com,
	linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
	max.chou@...ltek.com, alex_lu@...lsil.com.cn
Subject: Re: [PATCH v2 1/2] Bluetooth: btrtl: Firmware format v3 support

Hi Hilda,

kernel test robot noticed the following build warnings:

[auto build test WARNING on bluetooth/master]
[also build test WARNING on bluetooth-next/master linus/master v6.16-rc1 next-20250606]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Hilda-Wu/Bluetooth-btrtl-Firmware-format-v3-support/20250606-170957
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
patch link:    https://lore.kernel.org/r/20250606090559.896242-2-hildawu%40realtek.com
patch subject: [PATCH v2 1/2] Bluetooth: btrtl: Firmware format v3 support
config: arm-randconfig-r061-20250609 (https://download.01.org/0day-ci/archive/20250610/202506100621.JeEJ7e7X-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 8.5.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506100621.JeEJ7e7X-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/bluetooth/btrtl.c:1676:3-9: WARNING: NULL check before some freeing functions is not needed.
   drivers/bluetooth/btrtl.c:1678:3-9: WARNING: NULL check before some freeing functions is not needed.

vim +1676 drivers/bluetooth/btrtl.c

  1659	
  1660	void btrtl_free(struct btrtl_device_info *btrtl_dev)
  1661	{
  1662		struct rtl_subsection *entry, *tmp;
  1663		struct rtl_section_patch_image *image, *next;
  1664	
  1665		kvfree(btrtl_dev->fw_data);
  1666		kvfree(btrtl_dev->cfg_data);
  1667	
  1668		list_for_each_entry_safe(entry, tmp, &btrtl_dev->patch_subsecs, list) {
  1669			list_del(&entry->list);
  1670			kfree(entry);
  1671		}
  1672	
  1673		list_for_each_entry_safe(image, next, &btrtl_dev->patch_images, list) {
  1674			list_del(&image->list);
  1675			if (image->image_data)
> 1676				kvfree(image->image_data);
  1677			if (image->cfg_buf)
  1678				kvfree(image->cfg_buf);
  1679			kfree(image);
  1680		}
  1681	
  1682		kfree(btrtl_dev);
  1683	}
  1684	EXPORT_SYMBOL_GPL(btrtl_free);
  1685	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki