linux-kernel - Re: [PATCH net-next v2 0/4] udp_tunnel: remove rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aEdsBhZ4C--0ohYj@mini-arch>
Date: Mon, 9 Jun 2025 16:19:34 -0700
From: Stanislav Fomichev <stfomichev@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	pabeni@...hat.com, skalluru@...vell.com, manishc@...vell.com,
	andrew+netdev@...n.ch, michael.chan@...adcom.com,
	pavan.chebbi@...adcom.com, ajit.khaparde@...adcom.com,
	sriharsha.basavapatna@...adcom.com, somnath.kotur@...adcom.com,
	anthony.l.nguyen@...el.com, przemyslaw.kitszel@...el.com,
	tariqt@...dia.com, saeedm@...dia.com, louis.peens@...igine.com,
	shshaikh@...vell.com, GR-Linux-NIC-Dev@...vell.com,
	ecree.xilinx@...il.com, horms@...nel.org, dsahern@...nel.org,
	shuah@...nel.org, mheib@...hat.com, ruanjinjie@...wei.com,
	linux-kernel@...r.kernel.org, intel-wired-lan@...ts.osuosl.org,
	linux-rdma@...r.kernel.org, oss-drivers@...igine.com,
	linux-net-drivers@....com, linux-kselftest@...r.kernel.org,
	leon@...nel.org
Subject: Re: [PATCH net-next v2 0/4] udp_tunnel: remove rtnl_lock dependency

On 06/09, Jakub Kicinski wrote:
> On Mon,  9 Jun 2025 09:25:37 -0700 Stanislav Fomichev wrote:
> > Recently bnxt had to grow back a bunch of rtnl dependencies because
> > of udp_tunnel's infra. Add separate (global) mutext to protect
> > udp_tunnel state.
> 
> Appears to break the selftest, unfortunately:
> https://netdev.bots.linux.dev/contest.html?test=udp-tunnel-nic-sh&branch=net-next-2025-06-09--21-00

Argh, should have run it locally first :-(
Looks like there is a test that sets up pretty high sleep time (1 sec)
and expects entry to not appear during next 'ethtool --show-tunnels' run.

Gonna double check and remove the case if my understanding is correct.
Don't think there is much value in keeping the debugfs knob just for the
sake of this test? LMK if you disagree; otherwise gonna repost tomorrow.