linux-kernel - Re: [patch V2 06/45] genirq/proc: Switch to lock guards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb08e507-d46d-4700-aaa1-506331136b82@kernel.org>
Date: Mon, 9 Jun 2025 09:28:20 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Zenghui Yu <yuzenghui@...wei.com>, Thomas Gleixner <tglx@...utronix.de>
Cc: LKML <linux-kernel@...r.kernel.org>, Peter Zijlstra <peterz@...radead.org>
Subject: Re: [patch V2 06/45] genirq/proc: Switch to lock guards

On 09. 06. 25, 9:15, Zenghui Yu wrote:
>> >From cfad0937ffb724c2c51c8656c212ccefb09c8990 Mon Sep 17 00:00:00 2001
>> From: Zenghui Yu <yuzenghui@...wei.com>
>> Date: Sun, 8 Jun 2025 19:41:41 +0800
>> Subject: [PATCH] fixup! genirq/proc: Switch to lock guards
>>
>> Signed-off-by: Zenghui Yu <yuzenghui@...wei.com>
>> ---
>>   kernel/irq/proc.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c
>> index 29c2404e743b..5af8bd1f3ab4 100644
>> --- a/kernel/irq/proc.c
>> +++ b/kernel/irq/proc.c
>> @@ -86,7 +86,7 @@ static int irq_affinity_hint_proc_show(struct seq_file
>> *m, void *v)
>>   	if (!zalloc_cpumask_var(&mask, GFP_KERNEL))
>>   		return -ENOMEM;
>>
>> -	scoped_guard(raw_spinlock_irq, &desc->lock) {
>> +	scoped_guard(raw_spinlock_irqsave, &desc->lock) {
>>   		if (desc->affinity_hint)
>>   			cpumask_copy(mask, desc->affinity_hint);
>>   	}
>> @@ -298,7 +298,7 @@ static bool name_unique(unsigned int irq, struct
>> irqaction *new_action)
>>   	struct irq_desc *desc = irq_to_desc(irq);
>>   	struct irqaction *action;
>>
>> -	guard(raw_spinlock_irq)(&desc->lock);
>> +	guard(raw_spinlock_irqsave)(&desc->lock);
>>   	for_each_action_of_desc(desc, action) {
>>   		if ((action != new_action) && action->name &&
>>   		    !strcmp(new_action->name, action->name))
>> @@ -489,7 +489,7 @@ int show_interrupts(struct seq_file *p, void *v)
>>   	}
>>   	seq_putc(p, ' ');
>>
>> -	guard(raw_spinlock_irq)(&desc->lock);
>> +	guard(raw_spinlock_irqsave)(&desc->lock);
>>   	if (desc->irq_data.chip) {
>>   		if (desc->irq_data.chip->irq_print_chip)
>>   			desc->irq_data.chip->irq_print_chip(&desc->irq_data, p);
> 
> Plus,

Could you send proper patches, pls?

-- 
js
suse labs