linux-kernel - Re: [PATCH 2/7] mm: shmem: avoid setting error on splited entries in shmem_set_folio_swapin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <100d50f3-95df-86a3-7965-357d72390193@huaweicloud.com>
Date: Mon, 9 Jun 2025 09:19:27 +0800
From: Kemeng Shi <shikemeng@...weicloud.com>
To: Baolin Wang <baolin.wang@...ux.alibaba.com>, hughd@...gle.com,
 willy@...radead.org, akpm@...ux-foundation.org
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org,
 linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 2/7] mm: shmem: avoid setting error on splited entries in
 shmem_set_folio_swapin_error()



on 6/7/2025 2:20 PM, Baolin Wang wrote:
> 
> 
> On 2025/6/6 06:10, Kemeng Shi wrote:
>> When large entry is splited, the first entry splited from large entry
>> retains the same entry value and index as original large entry but it's
>> order is reduced. In shmem_set_folio_swapin_error(), if large entry is
>> splited before xa_cmpxchg_irq(), we may replace the first splited entry
>> with error entry while using the size of original large entry for release
>> operations. This could lead to a WARN_ON(i_blocks) due to incorrect
>> nr_pages used by shmem_recalc_inode() and could lead to used after free
>> due to incorrect nr_pages used by swap_free_nr().
> 
> I wonder if you have actually triggered this issue? When a large swap entry is split, it means the folio is already at order 0, so why would the size of the original large entry be used for release operations? Or is there another race condition?
All issues are found during review the code of shmem as I menthioned in
cover letter.
The folio could be allocated from shmem_swap_alloc_folio() and the folio
order will keep unchange when swap entry is split.

> 
>> Skip setting error if entry spliiting is detected to fix the issue. The
>> bad entry will be replaced with error entry anyway as we will still get
>> IO error when we swap in the bad entry at next time.
>>
>> Fixes: 12885cbe88ddf ("mm: shmem: split large entry if the swapin folio is not large")
>> Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>
>> ---
>>   mm/shmem.c | 21 +++++++++++++++------
>>   1 file changed, 15 insertions(+), 6 deletions(-)
>>
>> diff --git a/mm/shmem.c b/mm/shmem.c
>> index e27d19867e03..f1062910a4de 100644
>> --- a/mm/shmem.c
>> +++ b/mm/shmem.c
>> @@ -2127,16 +2127,25 @@ static void shmem_set_folio_swapin_error(struct inode *inode, pgoff_t index,
>>       struct address_space *mapping = inode->i_mapping;
>>       swp_entry_t swapin_error;
>>       void *old;
>> -    int nr_pages;
>> +    int nr_pages = folio_nr_pages(folio);
>> +    int order;
>>         swapin_error = make_poisoned_swp_entry();
>> -    old = xa_cmpxchg_irq(&mapping->i_pages, index,
>> -                 swp_to_radix_entry(swap),
>> -                 swp_to_radix_entry(swapin_error), 0);
>> -    if (old != swp_to_radix_entry(swap))
>> +    xa_lock_irq(&mapping->i_pages);
>> +    order = xa_get_order(&mapping->i_pages, index);
>> +    if (nr_pages != (1 << order)) {
>> +        xa_unlock_irq(&mapping->i_pages);
>>           return;
>> +    }
>> +    old = __xa_cmpxchg(&mapping->i_pages, index,
>> +               swp_to_radix_entry(swap),
>> +               swp_to_radix_entry(swapin_error), 0);
>> +    if (old != swp_to_radix_entry(swap)) {
>> +        xa_unlock_irq(&mapping->i_pages);
>> +        return;
>> +    }
>> +    xa_unlock_irq(&mapping->i_pages);
>>   -    nr_pages = folio_nr_pages(folio);
>>       folio_wait_writeback(folio);
>>       if (!skip_swapcache)
>>           delete_from_swap_cache(folio);
>