linux-kernel - Re: [PATCH] ata: pata_cs5536: fix build on 32-bit UML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aEas8qlzCQRJrfip@ryzen>
Date: Mon, 9 Jun 2025 11:44:18 +0200
From: Niklas Cassel <cassel@...nel.org>
To: Johannes Berg <johannes@...solutions.net>
Cc: linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org,
	Damien Le Moal <dlemoal@...nel.org>,
	Johannes Berg <johannes.berg@...el.com>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] ata: pata_cs5536: fix build on 32-bit UML

Hello Johannes,

On Fri, Jun 06, 2025 at 11:01:11AM +0200, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@...el.com>
> 
> On 32-bit ARCH=um, CONFIG_X86_32 is still defined, so it
> doesn't indicate building on real X86 machines. There's
> no MSR on UML though, so add a check for CONFIG_X86.
> 
> Reported-by: Arnd Bergmann <arnd@...db.de>

Reported-by: should be followed by either a Closes: or Link: tag, see:
https://docs.kernel.org/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes


Kind regards,
Niklas

> Signed-off-by: Johannes Berg <johannes.berg@...el.com>
> ---
>  drivers/ata/pata_cs5536.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/pata_cs5536.c b/drivers/ata/pata_cs5536.c
> index b811efd2cc34..73e81e160c91 100644
> --- a/drivers/ata/pata_cs5536.c
> +++ b/drivers/ata/pata_cs5536.c
> @@ -27,7 +27,7 @@
>  #include <scsi/scsi_host.h>
>  #include <linux/dmi.h>
>  
> -#ifdef CONFIG_X86_32
> +#if defined(CONFIG_X86) && defined(CONFIG_X86_32)
>  #include <asm/msr.h>
>  static int use_msr;
>  module_param_named(msr, use_msr, int, 0644);
> -- 
> 2.49.0
>