linux-kernel - Re: [RESEND PATCH] arm64: dts: ti: k3-j784s4-mcu-wakeup: Configure wkup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250609120032.yxmcyiw7dchv2kmp@wanted>
Date: Mon, 9 Jun 2025 07:00:32 -0500
From: Nishanth Menon <nm@...com>
To: "Kumar, Udit" <u-kumar1@...com>
CC: <vigneshr@...com>, <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <kristo@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <linux-kernel@...r.kernel.org>, <b-padhi@...com>
Subject: Re: [RESEND PATCH] arm64: dts: ti: k3-j784s4-mcu-wakeup: Configure
 wkup_uart0 with clock settings

On 12:47-20250608, Kumar, Udit wrote:
> Hello Nishanth
> 
> On 6/3/2025 9:31 PM, Nishanth Menon wrote:
> > On 09:54-20250603, Udit Kumar wrote:
> > > From: Bhavya Kapoor <b-kapoor@...com>
> > > 
> > > This commit adds the assigned-clocks and assigned-clock-parents
> > > properties for wkup_uart0 in J784S4. Specifically, the assigned-clocks
> > > property is set to reference the clock identified by
> > > "wkup_usart_mcupll_bypass_out0", ensuring the UART operates with the
> > > correct clock source.
> > > 
> > > The assigned-clock-parents property specifies "wkup_usart_clksel_out0"
> > > as the parent clock. This configuration is critical for establishing
> > > the proper clocking hierarchy, enabling the UART device to function
> > > reliably across different baud rates.
> > Please fix the commit message - not clear what specifically in the clock
> > hierarchy does permit the multiple baud rates.
> 
> need your advise here .
> 
> unlike other UART of main domain.  wkup_uart currently has two parents clock
> (clock-1 is at 96Mhz and clock-0 is at 19.2 Mhz).
> 
> By default, current fw selects clock-1 as parent.
> 
> Let me know, if explicitly we need to set parent as clock-1.
> 
> If yes then i will roll out v2 with current message , if no then please drop
> this patch

I personally do not see a need for the patch, then.
> 
> Thanks
> 
> Udit
> 
> > 
> > > Signed-off-by: Bhavya Kapoor <b-kapoor@...com>
> > You need to add your SoB.
> > > ---
> > > Link to v1: https://lore.kernel.org/all/20241009072056.3511346-1-b-kapoor@ti.com/
> > [..]

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D