linux-kernel - [PATCH v3 3/5] drm/amd: Avoid evicting resources at S5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250609024619.407257-4-superm1@kernel.org>
Date: Sun,  8 Jun 2025 21:46:17 -0500
From: Mario Limonciello <superm1@...nel.org>
To: "Rafael J . Wysocki" <rafael@...nel.org>,
	Alex Deucher <alexander.deucher@....com>,
	Bjorn Helgaas <bhelgaas@...gle.com>
Cc: amd-gfx@...ts.freedesktop.org (open list:RADEON and AMDGPU DRM DRIVERS),
	linux-pm@...r.kernel.org (open list:HIBERNATION (aka Software Suspend, aka swsusp)),
	linux-pci@...r.kernel.org (open list:PCI SUBSYSTEM),
	linux-kernel@...r.kernel.org (open list),
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Danilo Krummrich <dakr@...nel.org>,
	"James E . J . Bottomley" <James.Bottomley@...senPartnership.com>,
	"Martin K . Petersen" <martin.petersen@...cle.com>,
	dri-devel@...ts.freedesktop.org (open list:DRM DRIVERS),
	linux-scsi@...r.kernel.org (open list:SCSI SUBSYSTEM),
	linux-usb@...r.kernel.org (open list:USB SUBSYSTEM),
	Mario Limonciello <mario.limonciello@....com>,
	AceLan Kao <acelan.kao@...onical.com>,
	Kai-Heng Feng <kaihengf@...dia.com>,
	Mark Pearson <mpearson-lenovo@...ebb.ca>,
	Denis Benato <benato.denis96@...il.com>,
	Merthan Karakaş <m3rthn.k@...il.com>
Subject: [PATCH v3 3/5] drm/amd: Avoid evicting resources at S5

From: Mario Limonciello <mario.limonciello@....com>

Normally resources are evicted on dGPUs at suspend or hibernate and
on APUs at hibernate.  These steps are unnecessary when using the S4 callbacks
to put the system into S5.

Cc: AceLan Kao <acelan.kao@...onical.com>
Cc: Kai-Heng Feng <kaihengf@...dia.com>
Cc: Mark Pearson <mpearson-lenovo@...ebb.ca>
Cc: Denis Benato <benato.denis96@...il.com>
Cc: Merthan Karakaş <m3rthn.k@...il.com>
Signed-off-by: Mario Limonciello <mario.limonciello@....com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 8edd88328749b..c5d8f6d551238 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -4966,6 +4966,10 @@ static int amdgpu_device_evict_resources(struct amdgpu_device *adev)
 	if (!adev->in_s4 && (adev->flags & AMD_IS_APU))
 		return 0;
 
+	/* No need to evict when going to S5 through S4 callbacks */
+	if (system_state == SYSTEM_HALT || system_state == SYSTEM_POWER_OFF)
+		return 0;
+
 	ret = amdgpu_ttm_evict_resources(adev, TTM_PL_VRAM);
 	if (ret)
 		DRM_WARN("evicting device resources failed\n");
-- 
2.43.0