linux-kernel - Re: [PATCH] drivers: hv: Constify 'struct bin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <632c1404-cbf6-4ee6-909a-a18e78c1f96e@linux.microsoft.com>
Date: Mon, 9 Jun 2025 18:42:09 +0530
From: Naman Jain <namjain@...ux.microsoft.com>
To: Thomas Weißschuh <linux@...ssschuh.net>,
 "K. Y. Srinivasan" <kys@...rosoft.com>,
 Haiyang Zhang <haiyangz@...rosoft.com>, Wei Liu <wei.liu@...nel.org>,
 Dexuan Cui <decui@...rosoft.com>
Cc: linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: hv: Constify 'struct bin_attribute'



On 6/9/2025 4:35 PM, Thomas Weißschuh wrote:
> The sysfs core now allows instances of 'struct bin_attribute' to be
> moved into read-only memory. Make use of that to protect them against
> accidental or malicious modifications.
> 
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> ---
>   drivers/hv/vmbus_drv.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index 33b524b4eb5ef89d0111442a34d39874f02f0b70..38d2775dbe8730fd223d21188519b5f2b72e0804 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -1845,7 +1845,7 @@ static int hv_mmap_ring_buffer_wrapper(struct file *filp, struct kobject *kobj,
>   	return channel->mmap_ring_buffer(channel, vma);
>   }
>   
> -static struct bin_attribute chan_attr_ring_buffer = {
> +static const struct bin_attribute chan_attr_ring_buffer = {
>   	.attr = {
>   		.name = "ring",
>   		.mode = 0600,
> @@ -1871,7 +1871,7 @@ static struct attribute *vmbus_chan_attrs[] = {
>   	NULL
>   };
>   
> -static const struct bin_attribute *vmbus_chan_bin_attrs[] = {
> +static const struct bin_attribute *const vmbus_chan_bin_attrs[] = {
>   	&chan_attr_ring_buffer,
>   	NULL
>   };
> 
> ---
> base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> change-id: 20250609-sysfs-const-bin_attr-hv-135c9e53b325
> 
> Best regards,

Hello Thomas,
There is a recent change which leads to a conflict with your change
on latest linux-next tip as it brings half of the functionality
from your patch.

"drivers: hv: fix up const issue with vmbus_chan_bin_attrs"

Can you please rebase this.

The other part LGTM, considering you recently got this change
merged: "sysfs: constify attribute_group::bin_attrs"

Regards,
Naman