linux-kernel - Re: [PATCH v2] mmc: sdhci-of-arasan: Add shutdown callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFok6Ftr6OAHpy_qL3S17cecHT9f2tKWagCd+KvVFSmAFA@mail.gmail.com>
Date: Mon, 9 Jun 2025 15:26:19 +0200
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Paul Alvin <alvin.paulp@....com>
Cc: michal.simek@....com, adrian.hunter@...el.com, git@....com, 
	linux-arm-kernel@...ts.infradead.org, linux-mmc@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mmc: sdhci-of-arasan: Add shutdown callback

On Thu, 29 May 2025 at 12:49, Paul Alvin <alvin.paulp@....com> wrote:
>
> Implement shutdown hook to suspend host and disable all mmc clocks to
> increase power saving during shutdown or reboot.

So how long is the shutdown process for the platform? What do we really gain?

In general we don't quite care about power-savings during shutdown, as
we are going to turn off things anyway, right?

Kind regards
Uffe

>
> Signed-off-by: Paul Alvin <alvin.paulp@....com>
> ---
>
> Changes in v2:
> - Make use of platform suspend instead of driver suspend as driver
>   suspend will only get defined if PMC_SLEEP is configured which
>   results in build failure if it is not configured.
> - Updated commit description.
>
>  drivers/mmc/host/sdhci-of-arasan.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index 8c29676ab662..4abdad3c4e5b 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -2056,6 +2056,11 @@ static void sdhci_arasan_remove(struct platform_device *pdev)
>         clk_disable_unprepare(clk_ahb);
>  }
>
> +static void sdhci_arasan_shutdown(struct platform_device *pdev)
> +{
> +       sdhci_pltfm_suspend(&pdev->dev);
> +}
> +
>  static struct platform_driver sdhci_arasan_driver = {
>         .driver = {
>                 .name = "sdhci-arasan",
> @@ -2065,6 +2070,7 @@ static struct platform_driver sdhci_arasan_driver = {
>         },
>         .probe = sdhci_arasan_probe,
>         .remove = sdhci_arasan_remove,
> +       .shutdown = sdhci_arasan_shutdown,
>  };
>
>  module_platform_driver(sdhci_arasan_driver);
> --
> 2.44.1
>