linux-kernel - Re: [PATCH v3 2/4] rust: driver: Add ACPI id table support to Adapter trait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72=rerpj_Ut0x7dDb0O8dEh9SHaF1HVyyfMM83hz--QCJg@mail.gmail.com>
Date: Mon, 9 Jun 2025 15:42:02 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Igor Korotin <igor.korotin.linux@...il.com>
Cc: Danilo Krummrich <dakr@...nel.org>, Benno Lossin <lossin@...nel.org>, ojeda@...nel.org, 
	alex.gaynor@...il.com, rafael@...nel.org, gregkh@...uxfoundation.org, 
	linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org, 
	linux-acpi@...r.kernel.org, boqun.feng@...il.com, gary@...yguo.net, 
	bjorn3_gh@...tonmail.com, benno.lossin@...ton.me, a.hindborg@...nel.org, 
	aliceryhl@...gle.com, tmgross@...ch.edu, lenb@...nel.org, wedsonaf@...il.com, 
	viresh.kumar@...aro.org, alex.hung@....com, dingxiangfei2009@...il.com
Subject: Re: [PATCH v3 2/4] rust: driver: Add ACPI id table support to Adapter trait

On Mon, Jun 9, 2025 at 3:09 PM Igor Korotin
<igor.korotin.linux@...il.com> wrote:
>
> Let me know if this pattern is acceptable. To my opinion it is not much
> different from the original 2 functions conditioned by #[cfg] and
> requires some nasty changes.

In general, the more local a `cfg` can be made, the better, because we
can share more, e.g. the docs and signature.

But maybe in this case it doesn't work -- what would be the "nasty
changes" required?

Cheers,
Miguel