linux-kernel - Re: [PATCH net-next V2 07/11] net/mlx5e: SHAMPO: Headers page pool stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250609082022.5ef0c44a@kernel.org>
Date: Mon, 9 Jun 2025 08:20:22 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Tariq Toukan <ttoukan.linux@...il.com>
Cc: Cosmin Ratiu <cratiu@...dia.com>, "saeed@...nel.org" <saeed@...nel.org>,
 "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "hawk@...nel.org"
 <hawk@...nel.org>, "davem@...emloft.net" <davem@...emloft.net>,
 "john.fastabend@...il.com" <john.fastabend@...il.com>, "leon@...nel.org"
 <leon@...nel.org>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, "edumazet@...gle.com"
 <edumazet@...gle.com>, "linux-rdma@...r.kernel.org"
 <linux-rdma@...r.kernel.org>, "ast@...nel.org" <ast@...nel.org>,
 "pabeni@...hat.com" <pabeni@...hat.com>, "richardcochran@...il.com"
 <richardcochran@...il.com>, Dragos Tatulea <dtatulea@...dia.com>, Mark
 Bloch <mbloch@...dia.com>, "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
 Tariq Toukan <tariqt@...dia.com>, Saeed Mahameed <saeedm@...dia.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Gal Pressman
 <gal@...dia.com>, "daniel@...earbox.net" <daniel@...earbox.net>, Moshe
 Shemesh <moshe@...dia.com>
Subject: Re: [PATCH net-next V2 07/11] net/mlx5e: SHAMPO: Headers page pool
 stats

On Sun, 8 Jun 2025 13:09:16 +0300 Tariq Toukan wrote:
> >> We already expose the stats of the main pool in ethtool.
> >> So it will be an inconvenience to keep exposing half of the stats.
> >> So either we delete both or keep both. Some of us rely on this for
> >> debug
> >>  
> > 
> > What is the conclusion here?
> > Do we keep this patch, to have all the stats in the same place?
> > Or do we remove it, and then half of the stats will be accessible
> > through both ethtool and netlink, and the other half only via netlink?

Unfortunately by that logic we would never be able to move away from
deprecated APIs.

> IIRC, the netlink API shows only the overall/sum, right?

Wrong.

> ethtool stats show you per-ring numbers, this is very helpful for system 
> monitoring and perf debug.