[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6e162be6-0ab0-4cfe-a9f4-fad4f605e16b@linux.intel.com>
Date: Mon, 9 Jun 2025 11:22:11 +0800
From: "Mi, Dapeng" <dapeng1.mi@...ux.intel.com>
To: Salah Triki <salah.triki@...il.com>, Paolo Bonzini <pbonzini@...hat.com>,
kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kvm: preemption must be disabled when calling
smp_call_function_many
On 6/7/2025 6:39 PM, Salah Triki wrote:
> {Disable, Enable} preemption {before, after} calling
> smp_call_function_many().
>
> Signed-off-by: Salah Triki <salah.triki@...il.com>
> ---
> virt/kvm/kvm_main.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index eec82775c5bf..ab9593943846 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -209,7 +209,10 @@ static inline bool kvm_kick_many_cpus(struct cpumask *cpus, bool wait)
> if (cpumask_empty(cpus))
> return false;
>
> + preempt_disable();
> smp_call_function_many(cpus, ack_kick, NULL, wait);
> + preempt_enable();
> +
> return true;
> }
>
Reviewed-by: Dapeng Mi <dapeng1.mi@...ux.intel.com>
Powered by blists - more mailing lists