linux-kernel - RE: [PATCH next] cxl: fix return value in cxlctl_validate_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <684708602e1c8_1b0de02945d@iweiny-mobl.notmuch>
Date: Mon, 9 Jun 2025 11:14:24 -0500
From: Ira Weiny <ira.weiny@...el.com>
To: Shiju Jose <shiju.jose@...wei.com>, Alison Schofield
	<alison.schofield@...el.com>, Dan Carpenter <dan.carpenter@...aro.org>
CC: Davidlohr Bueso <dave@...olabs.net>, Jonathan Cameron
	<jonathan.cameron@...wei.com>, Dave Jiang <dave.jiang@...el.com>, "Vishal
 Verma" <vishal.l.verma@...el.com>, Ira Weiny <ira.weiny@...el.com>, "Dan
 Williams" <dan.j.williams@...el.com>, Li Ming <ming.li@...omail.com>, Fan Ni
	<fan.ni@...sung.com>, "linux-cxl@...r.kernel.org"
	<linux-cxl@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "kernel-janitors@...r.kernel.org"
	<kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH next] cxl: fix return value in
 cxlctl_validate_set_features()

Shiju Jose wrote:
> >-----Original Message-----
> >From: Alison Schofield <alison.schofield@...el.com>
> >Sent: 28 May 2025 16:23
> >To: Shiju Jose <shiju.jose@...wei.com>; Dan Carpenter
> ><dan.carpenter@...aro.org>
> >Cc: Davidlohr Bueso <dave@...olabs.net>; Jonathan Cameron
> ><jonathan.cameron@...wei.com>; Dave Jiang <dave.jiang@...el.com>; Vishal
> >Verma <vishal.l.verma@...el.com>; Ira Weiny <ira.weiny@...el.com>; Dan
> >Williams <dan.j.williams@...el.com>; Li Ming <ming.li@...omail.com>; Fan Ni
> ><fan.ni@...sung.com>; linux-cxl@...r.kernel.org; linux-
> >kernel@...r.kernel.org; kernel-janitors@...r.kernel.org
> >Subject: Re: [PATCH next] cxl: fix return value in cxlctl_validate_set_features()
> >
> >On Wed, May 28, 2025 at 11:11:41AM +0300, Dan Carpenter wrote:
> >> The cxlctl_validate_set_features() function is type bool.  It's
> >> supposed to return true for valid requests and false for invalid.
> >> However, this error path returns ERR_PTR(-EINVAL) which is true when
> >> it was intended to return false.
> >
> >Shiju - Can you trace this one through and add the impact statement?
> >Wondering if this is going to fail gracefully, or badly, further down this path?
> 
> Hi Alison,
> 
> This is introduced when following fwctl specific code
> move out of common  function (use both in fwctl and edac path)
> get_support_feature_info() to fwctl specific function
> cxlctl_validae_set_feature().
> "if (rpc_in->op_size < sizeof(uuid_t))
>       return ERR_PTR(-EINVAL);"
> 
> This may have an impact on fwctl side if the above check pass.
> 

I got a bit sidetracked by this conversation.

It seems the TLDR is:

This fix is not required.  But should be fixed for long term correctness.

With that interpretation.

Reviewed-by: Ira Weiny <ira.weiny@...el.com>