linux-kernel - Re: [PATCH v3 2/2] platform/x86: thinklmi: improved DMI handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aEg0K1OE6zhL97me@smile.fi.intel.com>
Date: Tue, 10 Jun 2025 16:33:31 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Mark Pearson <mpearson-lenovo@...ebb.ca>
Cc: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Hans de Goede <hdegoede@...hat.com>,
	Jonathan Corbet <corbet@....net>, ikepanhc@...il.com,
	Henrique de Moraes Holschuh <hmh@....eng.br>,
	Armin Wolf <W_Armin@....de>, linux-doc@...r.kernel.org,
	"platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>,
	ibm-acpi-devel@...ts.sourceforge.net,
	LKML <linux-kernel@...r.kernel.org>,
	kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v3 2/2] platform/x86: thinklmi: improved DMI handling

On Tue, Jun 10, 2025 at 08:28:49AM -0400, Mark Pearson wrote:
> On Tue, Jun 10, 2025, at 3:35 AM, Ilpo Järvinen wrote:
> > On Mon, 9 Jun 2025, Mark Pearson wrote:

...

> >> +		serial = dmi_get_system_info(DMI_PRODUCT_SERIAL);
> >> +		if (!serial)
> >> +			return -EINVAL;
> >
> > This should not return -EINVAL as it is not a problem with the input 
> > parameters. Perhaps -ENODEV would make sense instead?
> 
> Good point.
> Unless Andy strongly thinks I should drop this bit, I'll fix in the next version

If maintainers are okay to take this approach (both Kconfig and C file
changes), I am fine.

-- 
With Best Regards,
Andy Shevchenko