linux-kernel - Re: [PATCH] mm: slub: Wrap krealloc() __GFP_ZERO semantics diagram in literal code block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aEg_HtGuJ8Q8G_s8@hyeyoo>
Date: Tue, 10 Jun 2025 23:20:14 +0900
From: Harry Yoo <harry.yoo@...cle.com>
To: Bagas Sanjaya <bagasdotme@...il.com>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Documentation <linux-doc@...r.kernel.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        Feng Tang <feng.tang@...el.com>, Christoph Lameter <cl@...two.org>,
        David Rientjes <rientjes@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Roman Gushchin <roman.gushchin@...ux.dev>,
        Danilo Krummrich <dakr@...nel.org>
Subject: Re: [PATCH] mm: slub: Wrap krealloc() __GFP_ZERO semantics diagram
 in literal code block

On Tue, Jun 10, 2025 at 04:21:53PM +0700, Bagas Sanjaya wrote:
> Sphinx reports htmldocs warnings:
> 
> Documentation/core-api/mm-api:40: ./mm/slub.c:4936: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]
> Documentation/core-api/mm-api:40: ./mm/slub.c:4936: ERROR: Undefined substitution referenced: "--------". [docutils]
> 
> Fix the warning by wrapping krealloc() semantics diagram for __GFP_ZERO
> in literal code block.
> 
> Fixes: 489a744e5fb1 ("mm: krealloc: clarify valid usage of __GFP_ZERO")
> Signed-off-by: Bagas Sanjaya <bagasdotme@...il.com>
> ---

Hmm not sure what I am missing, but neither `make htmldocs` on my machine
nor docs.kernel.org [1] list kerneldoc for *_noprof() functions properly
(which should have been listed), so no errors show up...

[1] https://docs.kernel.org/core-api/mm-api.html

>  mm/slub.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/mm/slub.c b/mm/slub.c
> index 31e11ef256f90a..45a963e363d32b 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -4930,12 +4930,12 @@ __do_krealloc(const void *p, size_t new_size, gfp_t flags)
>   * When slub_debug_orig_size() is off, krealloc() only knows about the bucket
>   * size of an allocation (but not the exact size it was allocated with) and
>   * hence implements the following semantics for shrinking and growing buffers
> - * with __GFP_ZERO.
> + * with __GFP_ZERO::
>   *
> - *         new             bucket
> - * 0       size             size
> - * |--------|----------------|
> - * |  keep  |      zero      |
> + *           new             bucket
> + *   0       size             size
> + *   |--------|----------------|
> + *   |  keep  |      zero      |
>   *
>   * Otherwise, the original allocation size 'orig_size' could be used to
>   * precisely clear the requested size, and the new size will also be stored
> -- 
> An old man doll... just what I always wanted! - Clara
> 

-- 
Cheers,
Harry / Hyeonggon