linux-kernel - Re: [PATCH 2/3] PCI: Cleanup early_dump_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875bccf2-2922-4958-9385-ca1dcd508367@linux.intel.com>
Date: Tue, 10 Jun 2025 07:26:57 -0700
From: Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@...ux.intel.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Krzysztof Wilczyński <kw@...ux.com>,
 Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] PCI: Cleanup early_dump_pci_device()


On 6/10/25 3:58 AM, Ilpo Järvinen wrote:
> Convert 256 to PCI_CFG_SPACE_SIZE and 4 to sizeof(u32) and
> avoid i / 4 construct by changing the iteration.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>

>   drivers/pci/probe.c | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index c00634e5a2ed..f08e754c404b 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -3,6 +3,7 @@
>    * PCI detection and setup code
>    */
>   
> +#include <linux/array_size.h>
>   #include <linux/kernel.h>
>   #include <linux/delay.h>
>   #include <linux/init.h>
> @@ -1912,16 +1913,16 @@ static int pci_intx_mask_broken(struct pci_dev *dev)
>   
>   static void early_dump_pci_device(struct pci_dev *pdev)
>   {
> -	u32 value[256 / 4];
> +	u32 value[PCI_CFG_SPACE_SIZE / sizeof(u32)];
>   	int i;
>   
>   	pci_info(pdev, "config space:\n");
>   
> -	for (i = 0; i < 256; i += 4)
> -		pci_read_config_dword(pdev, i, &value[i / 4]);
> +	for (i = 0; i < ARRAY_SIZE(value); i++)
> +		pci_read_config_dword(pdev, i * sizeof(u32), &value[i]);
>   
>   	print_hex_dump(KERN_INFO, "", DUMP_PREFIX_OFFSET, 16, 1,
> -		       value, 256, false);
> +		       value, ARRAY_SIZE(value) * sizeof(u32), false);
>   }
>   
>   static const char *pci_type_str(struct pci_dev *dev)

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer