linux-kernel - Re: [PATCH net-next v2 1/4] udp_tunnel: remove rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3ba7b85cb4b57b0f6656c57971d368ebe4fd2b36.camel@nvidia.com>
Date: Tue, 10 Jun 2025 14:57:24 +0000
From: Cosmin Ratiu <cratiu@...dia.com>
To: "stfomichev@...il.com" <stfomichev@...il.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "dsahern@...nel.org" <dsahern@...nel.org>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"manishc@...vell.com" <manishc@...vell.com>, "oss-drivers@...igine.com"
	<oss-drivers@...igine.com>, "skalluru@...vell.com" <skalluru@...vell.com>,
	"mheib@...hat.com" <mheib@...hat.com>, "davem@...emloft.net"
	<davem@...emloft.net>, "przemyslaw.kitszel@...el.com"
	<przemyslaw.kitszel@...el.com>, "sriharsha.basavapatna@...adcom.com"
	<sriharsha.basavapatna@...adcom.com>, "ajit.khaparde@...adcom.com"
	<ajit.khaparde@...adcom.com>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"horms@...nel.org" <horms@...nel.org>, "anthony.l.nguyen@...el.com"
	<anthony.l.nguyen@...el.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "somnath.kotur@...adcom.com"
	<somnath.kotur@...adcom.com>, "ecree.xilinx@...il.com"
	<ecree.xilinx@...il.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"leon@...nel.org" <leon@...nel.org>, Saeed Mahameed <saeedm@...dia.com>,
	"shuah@...nel.org" <shuah@...nel.org>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "michael.chan@...adcom.com"
	<michael.chan@...adcom.com>, "shshaikh@...vell.com" <shshaikh@...vell.com>,
	Tariq Toukan <tariqt@...dia.com>, "ruanjinjie@...wei.com"
	<ruanjinjie@...wei.com>, "linux-rdma@...r.kernel.org"
	<linux-rdma@...r.kernel.org>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"pavan.chebbi@...adcom.com" <pavan.chebbi@...adcom.com>,
	"linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
	"louis.peens@...igine.com" <louis.peens@...igine.com>,
	"GR-Linux-NIC-Dev@...vell.com" <GR-Linux-NIC-Dev@...vell.com>,
	"linux-net-drivers@....com" <linux-net-drivers@....com>
Subject: Re: [PATCH net-next v2 1/4] udp_tunnel: remove rtnl_lock dependency

On Mon, 2025-06-09 at 09:25 -0700, Stanislav Fomichev wrote:
> Drivers that are using ops lock and don't depend on RTNL lock
> still need to manage it because udp_tunnel's RTNL dependency.
> Introduce new udp_tunnel_nic_lock and use it instead of
> rtnl_lock. Drop non-UDP_TUNNEL_NIC_INFO_MAY_SLEEP mode from
> udp_tunnel infra (udp_tunnel_nic_device_sync_work needs to
> grab udp_tunnel_nic_lock mutex and might sleep).
> 
> Cc: Michael Chan <michael.chan@...adcom.com>
> Suggested-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Stanislav Fomichev <stfomichev@...il.com>
Reviewed-by: Cosmin Ratiu <cratiu@...dia.com>