linux-kernel - Re: [PATCH v2] platform/chrome: chromeos_pstore: Add ecc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aEhK9knE1Fu_e_Sv@tzungbi-laptop>
Date: Tue, 10 Jun 2025 23:10:46 +0800
From: Tzung-Bi Shih <tzungbi@...nel.org>
To: Naoya Tezuka <naoyatezuka@...omium.org>
Cc: Benson Leung <bleung@...omium.org>, Kees Cook <kees@...nel.org>,
	Tony Luck <tony.luck@...el.com>,
	"Guilherme G . Piccoli" <gpiccoli@...lia.com>,
	chrome-platform@...ts.linux.dev, linux-kernel@...r.kernel.org,
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2] platform/chrome: chromeos_pstore: Add ecc_size module
 parameter

On Tue, Jun 10, 2025 at 02:04:58PM +0900, Naoya Tezuka wrote:
> On ChromiumOS devices, the ecc_size is set to 0 (check dmesg | grep ecc 
> to see `ecc: 0`): this disables ECC for ramoops region, even when 
> ramoops.ecc=1 is given to kernel command line parameter.
> 
> This patch introduces ecc_size module parameter to provide an method to 
> turn on ECC for ramoops and set different values of ecc_size per devices.

The doc [1] suggests to describe changes in imperative mood. If you have
chance to send next version, please fix it.  Otherwise, it doesn't really
bother me.

[1]: https://docs.kernel.org/process/submitting-patches.html

> @@ -9,6 +9,10 @@
>  #include <linux/platform_device.h>
>  #include <linux/pstore_ram.h>
>  
> +static int ecc_size;
> +module_param(ecc_size, int, 0444);

Does it need to be world-readable? How about 0400?

> @@ -117,6 +121,9 @@ static int __init chromeos_pstore_init(void)
>  {
>  	bool acpi_dev_found;
>  
> +	if (ecc_size > 0)
> +		chromeos_ramoops_data.ecc_info.ecc_size = ecc_size;

It seems `ecc_size` doesn't have an upper bound.  Wondering what would
be happened if it is a somehow large value.