linux-kernel - Re: [PATCH 1/1] net: fman_memac: Don't use of_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c4ce7df-dd5e-43a7-a496-bf5b89086e25@linux.dev>
Date: Tue, 10 Jun 2025 11:32:35 -0400
From: Sean Anderson <sean.anderson@...ux.dev>
To: Alexander Stein <alexander.stein@...tq-group.com>,
 Madalin Bucur <madalin.bucur@....com>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Russell King <linux@...linux.org.uk>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] net: fman_memac: Don't use of_property_read_bool on
 non-boolean property managed

On 6/10/25 07:40, Alexander Stein wrote:
> 'managed' is a non-boolean property specified in ethernet-controller.yaml.
> Since commit c141ecc3cecd7 ("of: Warn when of_property_read_bool() is
> used on non-boolean properties") this raises a warning. Use the
> replacement of_property_present() instead.
> 
> Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
> ---
>  drivers/net/ethernet/freescale/fman/fman_memac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fman/fman_memac.c b/drivers/net/ethernet/freescale/fman/fman_memac.c
> index 3925441143fac..0291093f2e4e4 100644
> --- a/drivers/net/ethernet/freescale/fman/fman_memac.c
> +++ b/drivers/net/ethernet/freescale/fman/fman_memac.c
> @@ -1225,7 +1225,7 @@ int memac_initialization(struct mac_device *mac_dev,
>  	 * be careful and not enable this if we are using MII or RGMII, since
>  	 * those configurations modes don't use in-band autonegotiation.
>  	 */
> -	if (!of_property_read_bool(mac_node, "managed") &&
> +	if (!of_property_present(mac_node, "managed") &&
>  	    mac_dev->phy_if != PHY_INTERFACE_MODE_MII &&
>  	    !phy_interface_mode_is_rgmii(mac_dev->phy_if))
>  		mac_dev->phylink_config.default_an_inband = true;

Reviewed-by: Sean Anderson <sean.anderson@...ux.dev>