linux-kernel - Re: [PATCH v2] (powerpc/512) Fix possible `dma_unmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <88be9850-fa2e-4470-b54c-55b6b8e2dd29@csgroup.eu>
Date: Tue, 10 Jun 2025 18:37:22 +0200
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Thomas Fourier <fourier.thomas@...il.com>
Cc: Anatolij Gustschin <agust@...x.de>,
 Madhavan Srinivasan <maddy@...ux.ibm.com>,
 Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>,
 Uwe Kleine-König <u.kleine-koenig@...libre.com>,
 "open list:LINUX FOR POWERPC EMBEDDED MPC5XXX"
 <linuxppc-dev@...ts.ozlabs.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] (powerpc/512) Fix possible `dma_unmap_single()` on
 uninitialized pointer



Le 10/06/2025 à 16:29, Thomas Fourier a écrit :
> [Vous ne recevez pas souvent de courriers de fourier.thomas@...il.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
> 
> If the device configuration fails (if `dma_dev->device_config()`),
> `sg_dma_address(&sg)` is not initialized and the jump to `err_dma_prep`
> leads to calling `dma_unmap_single()` on `sg_dma_address(&sg)`.
> 
> Signed-off-by: Thomas Fourier <fourier.thomas@...il.com>

Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>

> ---
>   arch/powerpc/platforms/512x/mpc512x_lpbfifo.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c b/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c
> index 9668b052cd4b..f251e0f68262 100644
> --- a/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c
> +++ b/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c
> @@ -240,10 +240,8 @@ static int mpc512x_lpbfifo_kick(void)
>          dma_conf.src_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
> 
>          /* Make DMA channel work with LPB FIFO data register */
> -       if (dma_dev->device_config(lpbfifo.chan, &dma_conf)) {
> -               ret = -EINVAL;
> -               goto err_dma_prep;
> -       }
> +       if (dma_dev->device_config(lpbfifo.chan, &dma_conf))
> +               return -EINVAL;
> 
>          sg_init_table(&sg, 1);
> 
> --
> 2.43.0
>