linux-kernel - Re: [PATCH] platform/chrome: cros_ec_typec: Defer probe on missing EC parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANFp7mXZXSJLYTO+2rkn+W6ki_hnzBPJ6s8MwtFFeyPqLbzQ1g@mail.gmail.com>
Date: Tue, 10 Jun 2025 10:00:10 -0700
From: Abhishek Pandit-Subedi <abhishekpandit@...omium.org>
To: Tomasz Michalec <tmichalec@...gle.com>
Cc: Benson Leung <bleung@...omium.org>, Jameson Thies <jthies@...gle.com>, 
	Andrei Kuchynski <akuchynski@...omium.org>, Tzung-Bi Shih <tzungbi@...nel.org>, 
	Guenter Roeck <groeck@...omium.org>, Konrad Adamczyk <konrada@...gle.com>, 
	chrome-platform@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	chromeos-krk-upstreaming@...gle.com
Subject: Re: [PATCH] platform/chrome: cros_ec_typec: Defer probe on missing EC parent

On Tue, Jun 10, 2025 at 8:39 AM Tomasz Michalec <tmichalec@...gle.com> wrote:
>
> If cros_typec_probe is called before EC device is registered,
> cros_typec_probe will fail. It may happen when cros-ec-typec.ko is
> loaded before EC bus layer module (e.g. cros_ec_lpcs.ko,
> cros_ec_spi.ko).
>
> Return -EPROBE_DEFER when cros_typec_probe doesn't get EC device, so
> the probe function can be called again after EC device is registered.
>
> Signed-off-by: Tomasz Michalec <tmichalec@...gle.com>
> ---
>  drivers/platform/chrome/cros_ec_typec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> index 7678e3d05fd3..f437b594055c 100644
> --- a/drivers/platform/chrome/cros_ec_typec.c
> +++ b/drivers/platform/chrome/cros_ec_typec.c
> @@ -1272,8 +1272,8 @@ static int cros_typec_probe(struct platform_device *pdev)
>
>         typec->ec = dev_get_drvdata(pdev->dev.parent);
>         if (!typec->ec) {
> -               dev_err(dev, "couldn't find parent EC device\n");
> -               return -ENODEV;
> +               dev_warn(dev, "couldn't find parent EC device\n");
> +               return -EPROBE_DEFER;
>         }
>
>         platform_set_drvdata(pdev, typec);
> --
> 2.50.0.rc0.604.gd4ff7b7c86-goog
>

Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@...omium.org>