linux-kernel - Re: [PATCH] Input: tca6416-keypad - Add OF support for driver instantiation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <174957707487.2226001.14497918275087340337.robh@kernel.org>
Date: Tue, 10 Jun 2025 12:37:54 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Tomáš Juřena <jurenatomas@...il.com>
Cc: conor+dt@...nel.org, linux-input@...r.kernel.org, 
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
 dmitry.torokhov@...il.com, krzk+dt@...nel.org
Subject: Re: [PATCH] Input: tca6416-keypad - Add OF support for driver
 instantiation


On Tue, 10 Jun 2025 17:46:10 +0200, Tomáš Juřena wrote:
> From: Tomas Jurena <jurenatomas@...il.com>
> 
> Adds support for instantiating the tca6416-keypad driver via
> Device Tree. If no platform data is present, the driver can now be
> probed based on OF bindings.
> 
> A corresponding Device Tree binding document is added at:
>   Documentation/devicetree/bindings/input/tca6416-keypad.yaml
> 
> This allows the driver to be used in systems that rely solely on the
> Device Tree for hardware description, such as embedded ARM platforms.
> 
> Tested on Toradex Ixora 1.3A board and Apalis imx8 SOM.
> 
> Signed-off-by: Tomas Jurena <jurenatomas@...il.com>
> ---
>  .../bindings/input/tca6416-keypad.yaml        | 87 ++++++++++++++++++
>  drivers/input/keyboard/tca6416-keypad.c       | 88 +++++++++++++++++--
>  2 files changed, 170 insertions(+), 5 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/input/tca6416-keypad.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/input/tca6416-keypad.yaml:9:13: [error] empty value in block mapping (empty-values)

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/tca6416-keypad.yaml: pinmask: missing type definition
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/tca6416-keypad.yaml: maintainers: None is not of type 'array'
	from schema $id: http://devicetree.org/meta-schemas/base.yaml#
Error: Documentation/devicetree/bindings/input/tca6416-keypad.example.dts:35.40-41 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/input/tca6416-keypad.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1519: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250610154609.1382818-1-jurenatomas@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.