linux-kernel - Re: [PATCH bpf-next v2] bpf, sockmap: Fix psock incorrectly pointing to sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <174957808176.2523637.14786222447534572080.git-patchwork-notify@kernel.org>
Date: Tue, 10 Jun 2025 17:54:41 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Jiayuan Chen <jiayuan.chen@...ux.dev>
Cc: bpf@...r.kernel.org, john.fastabend@...il.com, jakub@...udflare.com,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 horms@...nel.org, ast@...nel.org, daniel@...earbox.net,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next v2] bpf,
 sockmap: Fix psock incorrectly pointing to sk

Hello:

This patch was applied to bpf/bpf-next.git (net)
by Daniel Borkmann <daniel@...earbox.net>:

On Mon,  9 Jun 2025 10:59:08 +0800 you wrote:
> We observed an issue from the latest selftest: sockmap_redir where
> sk_psock(psock->sk) != psock in the backlog. The root cause is the special
> behavior in sockmap_redir - it frequently performs map_update() and
> map_delete() on the same socket. During map_update(), we create a new
> psock and during map_delete(), we eventually free the psock via rcu_work
> in sk_psock_drop(). However, pending workqueues might still exist and not
> be processed yet. If users immediately perform another map_update(), a new
> psock will be allocated for the same sk, resulting in two psocks pointing
> to the same sk.
> 
> [...]

Here is the summary with links:
  - [bpf-next,v2] bpf, sockmap: Fix psock incorrectly pointing to sk
    https://git.kernel.org/bpf/bpf-next/c/76be5fae32fe

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html