linux-kernel - Re: [RESEND PATCH] perf probe: Extend the quiet option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aEe7ojjNf-3k_OzU@google.com>
Date: Mon, 9 Jun 2025 21:59:14 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Aaron Tomlin <atomlin@...mlin.com>
Cc: arnaldo.melo@...il.com, peterz@...radead.org, mingo@...hat.com,
	acme@...nel.org, mark.rutland@....com,
	alexander.shishkin@...ux.intel.com, jolsa@...nel.org,
	irogers@...gle.com, adrian.hunter@...el.com,
	kan.liang@...ux.intel.com, linux-perf-users@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] perf probe: Extend the quiet option

Hello,

Sorry for the long delay.

On Sun, May 04, 2025 at 11:43:51AM +0100, Aaron Tomlin wrote:
> To provide a consistent and complete quiet mode, this patch expands the
> scope of the [-q|--quiet] option to suppress all informational messages,
> including those indicating successful event creation, in addition to the
> currently suppressed warnings and messages. For example:
> 
>     ❯ sudo ./perf probe --quiet --add proc_sys_open
>     ❯ echo $?
>     0

I don't think this change is needed.  I also see no messages before this
change.

Indeed, using -q/--quiet option makes verbose to be -1 which disables
any pr_info() messages.

Thanks,
Namhyung

> 
> Signed-off-by: Aaron Tomlin <atomlin@...mlin.com>
> ---
>  tools/perf/builtin-probe.c    | 16 +++++++++++-----
>  tools/perf/util/probe-event.h |  1 +
>  2 files changed, 12 insertions(+), 5 deletions(-)
> 
> diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
> index 69800e4d9530..aee756aad19d 100644
> --- a/tools/perf/builtin-probe.c
> +++ b/tools/perf/builtin-probe.c
> @@ -391,7 +391,7 @@ static int perf_add_probe_events(struct perf_probe_event *pevs, int npevs)
>  	}
>  
>  	/* Note that it is possible to skip all events because of blacklist */
> -	if (event) {
> +	if (event && !probe_conf.quiet) {
>  #ifndef HAVE_LIBTRACEEVENT
>  		pr_info("\nperf is not linked with libtraceevent, to use the new probe you can use tracefs:\n\n");
>  		pr_info("\tcd /sys/kernel/tracing/\n");
> @@ -467,8 +467,11 @@ static int perf_del_probe_events(struct strfilter *filter)
>  
>  	ret = probe_file__get_events(kfd, filter, klist);
>  	if (ret == 0) {
> -		strlist__for_each_entry(ent, klist)
> +		strlist__for_each_entry(ent, klist) {
> +			if (probe_conf.quiet)
> +				continue;
>  			pr_info("Removed event: %s\n", ent->s);
> +		}
>  
>  		ret = probe_file__del_strlist(kfd, klist);
>  		if (ret < 0)
> @@ -478,8 +481,11 @@ static int perf_del_probe_events(struct strfilter *filter)
>  
>  	ret2 = probe_file__get_events(ufd, filter, ulist);
>  	if (ret2 == 0) {
> -		strlist__for_each_entry(ent, ulist)
> +		strlist__for_each_entry(ent, ulist) {
> +			if (probe_conf.quiet)
> +				continue;
>  			pr_info("Removed event: %s\n", ent->s);
> +		}
>  
>  		ret2 = probe_file__del_strlist(ufd, ulist);
>  		if (ret2 < 0)
> @@ -531,7 +537,7 @@ __cmd_probe(int argc, const char **argv)
>  	struct option options[] = {
>  	OPT_INCR('v', "verbose", &verbose,
>  		    "be more verbose (show parsed arguments, etc)"),
> -	OPT_BOOLEAN('q', "quiet", &quiet,
> +	OPT_BOOLEAN('q', "quiet", &probe_conf.quiet,
>  		    "be quiet (do not show any warnings or messages)"),
>  	OPT_CALLBACK_DEFAULT('l', "list", NULL, "[GROUP:]EVENT",
>  			     "list up probe events",
> @@ -631,7 +637,7 @@ __cmd_probe(int argc, const char **argv)
>  	argc = parse_options(argc, argv, options, probe_usage,
>  			     PARSE_OPT_STOP_AT_NON_OPTION);
>  
> -	if (quiet) {
> +	if (probe_conf.quiet) {
>  		if (verbose != 0) {
>  			pr_err("  Error: -v and -q are exclusive.\n");
>  			return -EINVAL;
> diff --git a/tools/perf/util/probe-event.h b/tools/perf/util/probe-event.h
> index 71905ede0207..55771113791f 100644
> --- a/tools/perf/util/probe-event.h
> +++ b/tools/perf/util/probe-event.h
> @@ -10,6 +10,7 @@ struct nsinfo;
>  
>  /* Probe related configurations */
>  struct probe_conf {
> +	bool	quiet;
>  	bool	show_ext_vars;
>  	bool	show_location_range;
>  	bool	force_add;
> -- 
> 2.47.1
>